From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] add go@1.6
Date: Mon, 01 Aug 2016 00:55:59 +0200
Message-ID: <878twh4dts.fsf@gnu.org>
References: <87d1lyzlga.fsf@guixsd-mailerver.i-did-not-set--mail-host-address--so-tickle-me>
	<1469667655.4000333.678845385.2261EF5D@webmail.messagingengine.com>
	<87a8gzytt5.fsf@guixsd-mailerver.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37341)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bTzeR-00043k-FI
	for guix-devel@gnu.org; Sun, 31 Jul 2016 18:56:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bTzeO-0004Gy-BW
	for guix-devel@gnu.org; Sun, 31 Jul 2016 18:56:07 -0400
In-Reply-To: <87a8gzytt5.fsf@guixsd-mailerver.i-did-not-set--mail-host-address--so-tickle-me>
	(Matthew Jordan's message of "Sat, 30 Jul 2016 12:28:06 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Matthew Jordan <matthewjordandevops@yandex.com>
Cc: guix-devel@gnu.org

Hello!

Matthew Jordan <matthewjordandevops@yandex.com> skribis:

> From fbe9e4074cd27449d2337f62c7004993d087f6ba Mon Sep 17 00:00:00 2001
> From: Matthew Jordan <matthewjordandevops@yandex.com>
> Date: Thu, 26 May 2016 09:16:48 -0400
> Subject: [PATCH] gnu: Add go@1.6.
>
> * gnu/packages/golang.scm (go-1.6): New variable.
>
> Co-author: Efraim Flashner <efraim@flashner.co.il>
> Co-author: Andy Wingo <wingo@igalia.com>

Awesome!  I made small changes:

> +    (arguments
> +     `(#:modules ((ice-9 match)
> +                  (guix build gnu-build-system)
> +                  (guix build utils))
> +       #:tests? #f ; Tests are run by all.bash script
> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure)
> +         (add-after 'patch-generated-file-shebangs 'chdir
> +           (lambda _ (chdir "src")))

=E2=80=A6 using =E2=80=98substitute-keyword-arguments=E2=80=99 here to try =
to factorize build
phases with go@1.4, though in practice there are subtle differences
preventing the =E2=80=98prebuild=E2=80=99 and =E2=80=98install=E2=80=99 pha=
ses from being factorized.
Would be nice to improve it eventually, somehow.
> +    (inputs
> +     `(,@(package-inputs go-1.4)))

This is equivalent to:

  (inputs (package-inputs go-1.4))

which is equivalent to putting nothing, since we already =E2=80=98inherit=
=E2=80=99 from
go-1.4.

> +    (propagated-inputs
> +     `(,@(package-propagated-inputs go-1.4)))))

Ditto.

Committed, thank you!

Ludo=E2=80=99.