From: ng0 <ng0@we.make.ritual.n0.is>
To: Eric Bavier <ericbavier@openmailbox.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] import: cpan: Use tls to query api.metacpan.org.
Date: Tue, 30 Aug 2016 17:16:38 +0000 [thread overview]
Message-ID: <878tveuqh5.fsf@we.make.ritual.n0.is> (raw)
In-Reply-To: <20160830114904.2ec3512c@openmailbox.org>
Eric Bavier <ericbavier@openmailbox.org> writes:
> On Tue, 30 Aug 2016 12:57:47 +0000
> ng0 <ng0@we.make.ritual.n0.is> wrote:
>
>> From e5fb3767e652af0a94fb9817c81b23f37d676355 Mon Sep 17 00:00:00 2001
>> From: ng0 <ng0@we.make.ritual.n0.is>
>> Date: Tue, 30 Aug 2016 12:52:51 +0000
>> Subject: [PATCH] import: cpan: Use tls to query api.metacpan.org.
>>
>> * guix/import/cpan.scm (module->name module)[json-fetch]: Use tls for api.metacpan.org.
>> (cpan-fetch-module)[json-fetch]: Likewise.
>> ---
>> guix/import/cpan.scm | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/guix/import/cpan.scm b/guix/import/cpan.scm
>> index 213a155..5d393ac 100644
>> --- a/guix/import/cpan.scm
>> +++ b/guix/import/cpan.scm
>> @@ -2,6 +2,7 @@
>> ;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org>
>> ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
>> ;;; Copyright © 2016 Alex Sassmannshausen <alex@pompo.co>
>> +;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
>
> This patch may be one of those cases, discussed recently on the mailing
> list, where a copyright addition is not appropriate.
"Discussed recently on the mailing list" is one of those occassions
where I'd like to point out that it is a mailing list and therefore is not
very good in giving information unless you search for them.
If there was a conclusion to a longer discussion, please put it into the
contributing section of the manual, otherwise this will be repeated over
and over again, thanks.
I don't necessarily need this copyright addition, so if it looks
otherwise good, can you remove it for mie before commiting the patch, or
do you want me to send it again?
>> ;;;
>> ;;; This file is part of GNU Guix.
>> ;;;
>> @@ -83,7 +84,7 @@
>> "Return the base distribution module for a given module. E.g. the 'ok'
>> module is distributed with 'Test::Simple', so (module->dist-name \"ok\") would
>> return \"Test-Simple\""
>> - (assoc-ref (json-fetch (string-append "http://api.metacpan.org/module/"
>> + (assoc-ref (json-fetch (string-append "https://api.metacpan.org/module/"
>> module))
>> "distribution"))
>>
>> @@ -91,7 +92,7 @@ return \"Test-Simple\""
>> "Return an alist representation of the CPAN metadata for the perl module MODULE,
>> or #f on failure. MODULE should be e.g. \"Test::Script\""
>> ;; This API always returns the latest release of the module.
>> - (json-fetch (string-append "http://api.metacpan.org/release/"
>> + (json-fetch (string-append "https://api.metacpan.org/release/"
>> ;; XXX: The 'release' api requires the "release"
>> ;; name of the package. This substitution seems
>> ;; reasonably consistent across packages.
>
> Otherwise LGTM,
> `~Eric
--
ng0
For non-prism friendly talk find me on http://www.psyced.org
next prev parent reply other threads:[~2016-08-30 17:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 12:57 [PATCH] import: cpan: Use tls to query api.metacpan.org ng0
2016-08-30 16:49 ` Eric Bavier
2016-08-30 17:16 ` ng0 [this message]
2016-08-30 18:26 ` Eric Bavier
2016-08-30 18:51 ` ng0
2016-08-31 14:19 ` Ludovic Courtès
2016-08-31 15:00 ` Eric Bavier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tveuqh5.fsf@we.make.ritual.n0.is \
--to=ng0@we.make.ritual.n0.is \
--cc=ericbavier@openmailbox.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).