From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add hdf4
Date: Wed, 12 Oct 2016 22:28:59 +0200
Message-ID: <878tttmhv8.fsf@gnu.org>
References: <20161011.105744.1519945377775544087.post@thomasdanckaert.be>
	<87shs1ohgv.fsf@gnu.org>
	<20161012.205046.1873161880859659372.post@thomasdanckaert.be>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53808)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1buQ9D-0000d1-Aw
	for guix-devel@gnu.org; Wed, 12 Oct 2016 16:29:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1buQ98-0005TJ-MX
	for guix-devel@gnu.org; Wed, 12 Oct 2016 16:29:06 -0400
In-Reply-To: <20161012.205046.1873161880859659372.post@thomasdanckaert.be>
	(Thomas Danckaert's message of "Wed, 12 Oct 2016 20:50:46 +0200
	(CEST)")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Thomas Danckaert <post@thomasdanckaert.be>
Cc: guix-devel@gnu.org

Thomas Danckaert <post@thomasdanckaert.be> skribis:

>> Would =E2=80=9Chdf4-minimal=E2=80=9D sound appropriate here?  That=E2=80=
=99s a convention we
>> use
>> in similar cases.  Otherwise =E2=80=9Chdf4-alt=E2=80=9D is fine with me.
>
> With --disable-netcdf, the library still includes all the same
> features, the netCDF API function names are just mangled to avoid
> conflicts.  So it's not really more =E2=80=9Cminimal=E2=80=9D than the re=
gular HDF4
> :-)  I'd either go for something that explicitly mentions netCDF, or
> hdf4-alt because that's what Debian uses.

Works for me!

> From 3778ec2dfea4e5d7c0712ae1d354b463c8ee6694 Mon Sep 17 00:00:00 2001
> From: Thomas Danckaert <thomas.danckaert@gmail.com>
> Date: Wed, 28 Sep 2016 10:34:58 +0200
> Subject: [PATCH] gnu: Add hdf4
>
> * gnu/packages/maths.scm (hdf4, hdf4-alt): New variables.
> * gnu/packages/patches/hdf4-reproducibility.patch: New file.
> * gnu/packages/patches/hdf4-shared-fortran.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add patches.
>
> Co-Authored-By: Jeremy Robst <jpro@bas.ac.uk>

Applied, thanks!

Ludo=E2=80=99.