From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: cross-libc: Use the correct libc.
Date: Mon, 31 Oct 2016 18:49:18 +0100
Message-ID: <878tt4pfxd.fsf@gnu.org>
References: <eeec8c69-fb81-b2f6-b2ac-0d0e6d8de1ad@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39156)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1c1Gi4-0004l4-4t
	for guix-devel@gnu.org; Mon, 31 Oct 2016 13:49:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1c1Gi0-0005lH-QK
	for guix-devel@gnu.org; Mon, 31 Oct 2016 13:49:24 -0400
In-Reply-To: <eeec8c69-fb81-b2f6-b2ac-0d0e6d8de1ad@gmail.com> (Manolis
	Ragkousis's message of "Thu, 11 Aug 2016 21:56:27 +0300")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>

Hi Manolis, and sorry for the delay on this one!

Manolis Ragkousis <manolis837@gmail.com> skribis:

> I noticed that in commit ef21276053b980 from core-updates-next I am
> using (cross-libc-for-target ...) only in one place while I should have
> used (let ((libc (cross-libc-for-target target))) (package ...
>
> With this patch I fix this.
>
> Thank you,
> Manolis
>
> From b0481b1af1ea64cdfc1dcac6f2c1f9a24dc9a70b Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <manolis837@gmail.com>
> Date: Thu, 11 Aug 2016 21:28:00 +0300
> Subject: [PATCH] gnu: cross-libc: Use the correct libc.
>
> * gnu/packages/cross-base.scm (cross-libc): Use cross-libc-for-target
> to determine the correct libc to use.

LGTM, for =E2=80=98core-updates=E2=80=99.

Before pushing, please make sure that:

  ./pre-inst-env guix build -s x86_64-linux coreutils
  ./pre-inst-env guix build -s armhf-linux coreutils
  ./pre-inst-env guix build --target=3Darm-linux-gnueabihf coreutils -n

are unchanged (I suppose they have substitutes available.)

Thanks!

Ludo=E2=80=99.