From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 6/6] gnu: Add grub-efi.
Date: Sun, 06 Nov 2016 23:00:16 +0100
Message-ID: <878tsww9ov.fsf@gnu.org>
References: <20161105125511.29383-1-mbakke@fastmail.com>
	<20161105125511.29383-7-mbakke@fastmail.com>
	<20161105185803.GA11667@jasmine>
	<87h97l67kz.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40292)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1c3VUE-0000pw-EP
	for guix-devel@gnu.org; Sun, 06 Nov 2016 17:00:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1c3VUB-0004Rz-BA
	for guix-devel@gnu.org; Sun, 06 Nov 2016 17:00:22 -0500
In-Reply-To: <87h97l67kz.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>
	(Marius Bakke's message of "Sat, 05 Nov 2016 19:38:04 +0000")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org

Marius Bakke <mbakke@fastmail.com> skribis:

> Leo Famulari <leo@famulari.name> writes:
>
>> On Sat, Nov 05, 2016 at 12:55:11PM +0000, Marius Bakke wrote:
>>> * gnu/packages/grub.scm (grub-efi): New variable.
>>> ---
>>>  gnu/packages/grub.scm | 21 +++++++++++++++++++++
>>>  1 file changed, 21 insertions(+)
>>>=20
>>> diff --git a/gnu/packages/grub.scm b/gnu/packages/grub.scm
>>> index ffce1bf..e06216f 100644
>>> --- a/gnu/packages/grub.scm
>>> +++ b/gnu/packages/grub.scm
>>> @@ -157,3 +157,24 @@ on the same computer; upon booting the computer, t=
he user is presented with a
>>>  menu to select one of the installed operating systems.")
>>>      (license gpl3+)
>>>      (properties '((cpe-name . "grub2")))))
>>> +
>>> +(define-public grub-efi
>>> +  (package
>>> +    (inherit grub)
>>> +    (name "grub-efi")
>>> +    (synopsis (string-append (package-synopsis grub) " (UEFI version)"=
))
>>> +    (inputs
>>> +     `(("efibootmgr" ,efibootmgr)
>>> +       ,@(package-inputs grub)))
>>> +    (arguments
>>> +     #:tests? #f ; FIXME: 40 failures, 24 skipped, 17 passed.
>>
>> Does this package work for you?
>
> Oops, not sure what went wrong when fixing up this package for
> publishing. Updated patch attached.

I think Leo was asking whether you could get a bootable system with it.
:-)

> From 940c03c7dcddec019e27f6eb1470aeab4db57799 Mon Sep 17 00:00:00 2001
> From: Marius Bakke <mbakke@fastmail.com>
> Date: Thu, 20 Oct 2016 17:26:52 +0100
> Subject: [PATCH] gnu: Add grub-efi.
>
> * gnu/packages/grub.scm (grub-efi): New variable.

[...]

> +    (name "grub-efi")
> +    (synopsis (string-append (package-synopsis grub) " (UEFI version)"))

Please use a literal string for =E2=80=98synopsis=E2=80=99; use of =E2=80=
=98string-append=E2=80=99 like
this prevents i18n.

> +     `(#:tests? #f ; FIXME: 40 failures, 24 skipped, 17 passed.

It would be good to investigate, especially if the tests pass in the
=E2=80=98grub=E2=80=99 package.

Also, what=E2=80=99s the rationale for making =E2=80=98grub-efi=E2=80=99 se=
parate instead of
incorporating the changes in =E2=80=98grub=E2=80=99 proper?  Are there issu=
es around the
portability of =E2=80=98efibootmgr=E2=80=99, or an increased closure size?

Thanks for working on it!

Ludo=E2=80=99.