From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: Not patching shebang in git hook samples ?
Date: Mon, 23 Jan 2017 15:04:30 +0100
Message-ID: <878tq1x47l.fsf@gnu.org>
References: <20170122130124.GA25096@jocasta.intra>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37748)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cVfEc-0006JQ-KE
	for guix-devel@gnu.org; Mon, 23 Jan 2017 09:04:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cVfEX-0000Fn-NW
	for guix-devel@gnu.org; Mon, 23 Jan 2017 09:04:38 -0500
In-Reply-To: <20170122130124.GA25096@jocasta.intra> (John Darrington's message
	of "Sun, 22 Jan 2017 14:01:24 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: John Darrington <john@darrington.wattle.id.au>
Cc: guix-devel@gnu.org

John Darrington <john@darrington.wattle.id.au> skribis:

> The git package ships with a number of sample hook files.  These are shel=
l scripts and
> therefore the #!/bin/sh line gets substituted at  build time.
>
> However these files get installed into every git repostory that is create=
d, and users
> are invited to use them as templates for their own hooks.
>
> This will be fine until both git and bash are updated.  Now the original =
bash is free
> to be garbage collected.  If that happens, the path:=20
> #!/gnu/store/qkw4zrwfybxww8f56nkb6hggxambk89b-bash-4.4.0/bin/sh
> will no longer exist.
>
> I suggest what we turn off the shebang patching for the files in share/te=
mplates for git.

Agreed, it=E2=80=99s a bug.

Ludo=E2=80=99.