From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: Broken tests Date: Mon, 13 Feb 2017 16:08:00 +0100 Message-ID: <878tpab033.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46402) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cdIEY-0000s2-Up for guix-devel@gnu.org; Mon, 13 Feb 2017 10:08:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cdIEW-0000Dy-6o for guix-devel@gnu.org; Mon, 13 Feb 2017 10:08:06 -0500 In-Reply-To: (Federico Beffa's message of "Mon, 13 Feb 2017 09:44:01 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Federico Beffa Cc: guix-devel Hello, Federico Beffa skribis: > On Sat, Feb 11, 2017 at 6:15 PM, David Craven wrote: >> Hi! >> >>> Revert "import: json: Explicitly ask for JSON data." >>> This reverts commit 81e0bc1834490a1a8092c75a0733b15c2b407285. >> >> I reverted this commit in my local repository for now, it breaks the >> pypi, crate and some other test I can't recall (gem and/or cpan). > > The importers seems to be working as before. I believe that the > problem is with the tests. They replace the function 'http-fetch', but > do not replicate the signature of the original function and instead > use a different one. Indeed. Fixed in ce8963c5b7a728257920aeceeb89e40d166d09f4. Please make sure to run the test suite before changing non-package code. In general, I think we can agree on reverting changes that break the tests until a solution is proposed (and once the original author has been notified, of course). That sounds like reasonable policy to me. Thoughts? Ludo=E2=80=99.