From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: proposal: with-file-writeable Date: Thu, 15 Feb 2018 15:16:21 +0100 Message-ID: <878tbuwd6y.fsf@fastmail.com> References: <87wozfp2wk.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emKKr-0001Gm-7L for guix-devel@gnu.org; Thu, 15 Feb 2018 09:16:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emKKn-00040x-80 for guix-devel@gnu.org; Thu, 15 Feb 2018 09:16:29 -0500 In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?utf-8?Q?G=C3=A1bor?= Boskovits , Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: Guix-devel --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable G=C3=A1bor Boskovits writes: > Ok, the keep it this way. Another question, this came up, as > I was trying to find a nice solution to reset-gzip-timestamps failing. > I got different pieces of advice if I should reset the permissions after > resetting the timestamp, but I'm still not sure. It seems that the easiest > way to this would be to just add a call to make-file-writable to the phase > at the beginning, as we finally end up with a read-only one in the store > anyway. I feel that reseting the permissions is unneccesary additional > complexity. WDYT? In the "strip" phase we already call "make-file-writeable" unconditionally, so doing it in reset-gzip-permissions as well should be okay I think. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlqFljUACgkQoqBt8qM6 VPp7GAf/UwozF9hFWV26HUIwbF1Y3swRS9bowZA8EIvPlNJHsXnviwcHgFEYM+sl 3wmUaN5E6GczwtNBpAt2NJX+eXjbWZfhwML47unPR/X/6oPhkbPLCZdlBaV8DJF3 klq7N6WeCFGFbthuQ+7T3BnW5i3hMhKDgTOmc1Twpb+AvKXrcZ2mzhHRqNSe9YFp igw14QF2Sl1ndrkdMJXvq+lDVbMS5rfFQB7Y8V/XU+sllAIK5iIPSCdNqTZsTZEL +/ddp9foiqbXMJunAvOZBpvTYqa9x5mWToeWQtVf7TnkcK4NOJNKboW6AGpWuqHd adCkViSzstOlb34HrWmFiqvFH2QeYg== =of/A -----END PGP SIGNATURE----- --=-=-=--