From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: 01/01: gnu: mit-scheme: Update to 10.1.3. Date: Fri, 14 Dec 2018 23:45:35 -0500 Message-ID: <878t0rbdo5.fsf@netris.org> References: <20181213170057.18025.51445@vcs0.savannah.gnu.org> <20181213170058.5B7372092C@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36722) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gY1qa-0001wi-25 for guix-devel@gnu.org; Fri, 14 Dec 2018 23:46:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gY1qW-0002K5-Ud for guix-devel@gnu.org; Fri, 14 Dec 2018 23:46:40 -0500 Received: from world.peace.net ([64.112.178.59]:44194) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gY1qW-0002K1-Qj for guix-devel@gnu.org; Fri, 14 Dec 2018 23:46:36 -0500 In-Reply-To: <20181213170058.5B7372092C@vcs0.savannah.gnu.org> (guix-commits's message of "Thu, 13 Dec 2018 12:00:58 -0500 (EST)") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Kei Kebreau Cc: guix-devel@gnu.org Hi Kei, guix-commits@gnu.org writes: > kkebreau pushed a commit to branch master > in repository guix. > > commit d870cc5e8acfed6fee318a66c3ffc7244aa376a1 > Author: Kei Kebreau > Date: Thu Dec 13 08:32:50 2018 -0500 > > gnu: mit-scheme: Update to 10.1.3. > > * gnu/packages/scheme.scm (mit-scheme): Update to 10.1.3. > [arguments]: Update 'unpack', 'configure-doc', and 'install-doc' phases > accordingly. > [supported-systems]: Limit to i686-linux and x86_64-linux. [...] > @@ -177,24 +171,21 @@ > ("x86_64-linux" > (string-append version "-x86-64")) > ("i686-linux" > - (string-append version "-i386")) > - (_ > - (string-append "c-" version))) > + (string-append version "-i386"))) > ".tar.gz")) > (sha256 > (match (%current-system) > ("x86_64-linux" > (base32 > - "1skzxxhr0iq96bf0j5m7mvf3i4sppfyfa6gpqn34mwgkw1fx8274")) > + "03m7cc035w3avs91j2pcz9f15ssgvgp3rm045d1vbydqrkzfyw8k")) > ("i686-linux" > (base32 > - "1fmlpnhf5a75db93phajh4ysbdgrgl72v45lk3kznriprl0a7jc6")) > - (_ > - (base32 > - "0w5ib5vsidihb4hb6fma3sp596ykr8izagm57axvgd6lqzwicsjg")))))))) > + "05sjyz90xxfnmi87qv8x0yx0fcallnzl1dciygdafp317pn489is")))))))) Without the fallback cases in these 'match' forms, this package definition raises an exception when asked to generate the derivation on non-Intel systems. Ludovic partly reverted your changes here: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=966629a114fd90153784dfdbe5e332e0ac94f1bc This commit also broke the 'guix' package on armhf-linux, and probably on other non-Intel systems as well, https://hydra.gnu.org/build/3281991 although admittedly I found this surprising. > ;; Fails to build on MIPS, see . > - (supported-systems '("x86_64-linux" "i686-linux" "armhf-linux")) > + ;; Also, the portable C version of MIT/GNU Scheme did not work in time for > + ;; release in version 10.1. > + (supported-systems '("x86_64-linux" "i686-linux")) In general, please do not remove a system from 'supported-systems' unless there is good reason to believe that it would be prohibitively difficult to support the package on that system. If there is merely a bug or some minor unfinished work that prevents a package from building on a given system, that is not sufficient grounds to remove it from 'supported-systems'. Thanks, Mark