From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Baines Subject: Re: 01/01: python: Honor '--cores=...' in tests. Date: Sat, 15 Dec 2018 17:53:56 +0000 Message-ID: <878t0qn0az.fsf@cbaines.net> References: <20181117064344.29159.44615@vcs0.savannah.gnu.org> <20181117064345.133A42043C@vcs0.savannah.gnu.org> <87y38sw2ey.fsf@cbaines.net> <87va3ww1iq.fsf@cbaines.net> <20181214115756.0f22bc72@centurylink.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50176) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYE8b-0005FV-Gx for guix-devel@gnu.org; Sat, 15 Dec 2018 12:54:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gYE8W-0001un-KJ for guix-devel@gnu.org; Sat, 15 Dec 2018 12:54:05 -0500 Received: from mira.cbaines.net ([2a01:7e00::f03c:91ff:fe69:8da9]:59872) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYE8W-0001ts-Cw for guix-devel@gnu.org; Sat, 15 Dec 2018 12:54:00 -0500 In-reply-to: <20181214115756.0f22bc72@centurylink.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Eric Bavier Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Eric Bavier writes: > On Fri, 14 Dec 2018 15:50:37 +0000 > Christopher Baines wrote: > >> Christopher Baines writes: >> >> > Eric Bavier writes: >> > >> > Since all the python packages look to inherit from python-2.7 that's >> > being changed here, perhaps this worked for some of them (I know you >> > mentioned python-minimal in one message), but not all of them, or at >> > least python2? >> >> Just got around to testing this, moving this change to python-3.7, from >> python-2.7 fixes the python-2.7 build for me, but I haven't checked >> how that affects how many cores are actually used when running the tests. > > Strange. I recall testing this patch on both python2 and python. Not > sure what has changed since then. Ok, I've checked out the relevant commit and I can reproduce the issue there. I've also tried to compare the behaviour between the python2 and python3 packages. I think the reason why it might work for python3, and not python2, is that the python2 package seems to include the -l option by default, whereas the python3 package doesn't. Looking at the -l option, it's something about detecting tests that leak memory, which doesn't sound that important, so maybe the thing to do is to patch out the use of -l in the python2 package. What do you think? Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlwVP7RfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XdaFxAAlJumiIS6YB0SSb5nQB73nc7KqKQAiTUsZwhTz/cQovh5g4tbRHDyG9Er 6gnM8jWH3RVZDALFV81Ii8a4kOI/7tdPnMr8E03KhEAeDxqxUL9LkJ2lpFWND8g2 LIEKU2soyulFC2mbihifPLc6JEmrXs4uBTkIv6C8f+wtsCJ/Q0Aq9jjHXkPyNoG2 4LCkVVY5DW3FjEM2HWOsJJ4tIbbazOCovEPDRZZOxWxLoxQpYkcqb/4GtOwr2M1s ti97fRW6Thi65yYE/GQQCkUR7+e/IXacQiEQdIE8HyNsxU2K2XGK5e1JMG7+M+tR fEBxF01TdzpGGPmcre81uwIMBFj6+t/7psWxATZg4qjAE7wrabXZe7TQ19GLwFsl QAhjcQE6HoQnl+UJvzdeHBX/nfvwbhEp3qTOP+6vnRRVH9tYSxi/Izin5eAUr+xg zxT+O5NSVmmhy00P1h6h19IxRyeXViTmWq0hzbRYv/KsYZ6HiFFO7KYFGYFFmnAD K2+S4mBmXjESwui6Pc1a9dW7o1Bz/N7Q435Bbptwj+JgmYFB3lJmoJgy4X71mOCu kWAeLB7+rIUv9LJmXhcoGytrsexvOG055oUvQkEm+f6kkviRA7fVsppt6O2dVjug 0fniwTEfEE123HRysLRbATiij44HSEjGj01w9/mlMus9VQpjV9k= =eJ1T -----END PGP SIGNATURE----- --=-=-=--