From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: 04/07: gnu: strace: Update to 5.2.
Date: Tue, 06 Aug 2019 01:20:22 -0400
Message-ID: <878ss6ooni.fsf@netris.org>
References: <20190804160223.1357.19402@vcs0.savannah.gnu.org>
 <20190804160224.A29E4209DE@vcs0.savannah.gnu.org>
 <878ss7a7zb.fsf@netris.org> <871rxz341g.fsf@devup.no>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:48940)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <mhw@netris.org>) id 1hurtm-0003z7-0s
 for guix-devel@gnu.org; Tue, 06 Aug 2019 01:20:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <mhw@netris.org>) id 1hurtk-0001Bt-R9
 for guix-devel@gnu.org; Tue, 06 Aug 2019 01:20:37 -0400
Received: from world.peace.net ([64.112.178.59]:60944)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <mhw@netris.org>) id 1hurtk-0001BX-Nj
 for guix-devel@gnu.org; Tue, 06 Aug 2019 01:20:36 -0400
In-Reply-To: <871rxz341g.fsf@devup.no>
List-Id: "Development of GNU Guix and the GNU System distribution."
 <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org

Hi Marius,

Marius Bakke <mbakke@fastmail.com> wrote:

> Mark H Weaver <mhw@netris.org> writes:
>
>> This new version of strace failed to build twice in a row on my Thinkpad
>> X200 running the Guix system and Linux-libre 5.2.5.  I've not yet made a
>> third attempt.  strace-5.1 has always built successfully on this system.
>>
>> Specifically, strace-5.2 fails 4 of its tests on my system.  See below
>> for the relevant entries from tests/test-suite.log.
>
> Yay, test failures that vary based on hardware or kernel.

Heh :)

> I found this commit upstream which touches the four failing tests,
> though I don't really understand what it does:
>
> https://github.com/strace/strace/commit/4377e3a1535a0ec3a42da8a1366ad6943f4efa0e
>
> Mark: can you try the attached patch and see if it makes a difference?
> Strace (still) builds for me with this patch, at least.

It made no difference, but further investigation revealed that the
changes implied by the patch (e.g. changing -a22 to -a20 in the
ipc_msgbuf-Xraw test) were not actually applied in practice.  Those
switches are included in the 'tests/test-suite.log' output, and they are
unchanged from before this patch was applied.

It turns out that many other files included in the release tarball are
generated from 'tests/gen_tests.in' using the 'tests/gen_tests.sh'
script, and they are not automatically updated by the normal build
process after patching 'tests/gen_tests.in', at least not when all the
files have the same timestamp.

To be continued ...

     Thanks,
       Mark