From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timothy Sample Subject: Re: Please merge wip-haskell-updates (Re: [bug#36807] remove obsolete broken haskell packages) Date: Wed, 07 Aug 2019 23:42:39 -0400 Message-ID: <878ss4pbkg.fsf@ngyro.com> References: <87muh2ckdn.fsf@ngyro.com> <21D6742C-75C4-47A0-9F1A-0C911C24E3DA@vllmrt.net> <87mugmq5ll.fsf@ngyro.com> <3C8EAC60-7073-4528-BC5D-548A018F08D8@vllmrt.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:41883) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvZK8-0005at-JX for guix-devel@gnu.org; Wed, 07 Aug 2019 23:42:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hvZK7-0000Cf-4z for guix-devel@gnu.org; Wed, 07 Aug 2019 23:42:44 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:43643) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hvZK6-0000CS-S5 for guix-devel@gnu.org; Wed, 07 Aug 2019 23:42:43 -0400 In-Reply-To: <3C8EAC60-7073-4528-BC5D-548A018F08D8@vllmrt.net> (Robert Vollmert's message of "Tue, 6 Aug 2019 09:04:39 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Robert Vollmert Cc: guix-devel@gnu.org, 36807@debbugs.gnu.org Hi Robert, I pushed my touched-up version of your branch to master! (See commits a62ddb748f=E2=80=93caa366ec23.) Now I will enjoy closing all those patches= . :) I hope all my changes are okay. Besides the changes to =E2=80=9Cghc-8.6=E2= =80=9D, I mostly altered formatting, descriptions, and commit messages to better fit our conventions. I=E2=80=99ve added a few comments below. Robert Vollmert writes: > Hi Timothy, > >> On 6. Aug 2019, at 06:29, Timothy Sample wrote: >>=20 >>> #36692: GHC version 8.6.5 (just as a package for now, not used to build >>> anything) >>=20 >> I made some bigger changes here. Mostly, I made use of >> =E2=80=9Csubstitute-keyword-arguments=E2=80=9D to reuse more code from = =E2=80=9Cghc-8.4=E2=80=9D. >>=20 >> Why do you use =E2=80=9Cpatch=E2=80=9D instead of =E2=80=9Csubstitute*= =E2=80=9D to disable the failing >> tests? I see from your previous patches that you used to do it with >> =E2=80=9Csubstitute*=E2=80=9D. > > It would be ok to go back to the old state. I moved to a patch over the > process of getting the build to pass, which involved skipping more tests. > That said, substitute has several downsides compared to patches: > - patch is easier to read Personally I find them about the same, but my impression is that the =E2=80=9Csubstitute*=E2=80=9D approach is more common. I used it to try to= be more consistent. > - patch doesn=E2=80=99t fail silently This is a real problem, and there was a recent discussion on changing the semantics of =E2=80=9Csubstitute*=E2=80=9D to fix this (I can=E2=80=99t= find it now, though). We would probably find a lot of unnecessary calls to =E2=80=9Csubstitute*=E2=80=9D if we could easily see when it does nothing. >>> no ticket: Skip tests for three Haskell packages that fail on i686 only >>> (and seem harmless): ghc-trifecta, ghc-yaml, ghc-libmpd-haskell. >>=20 >> This seems reasonable to me, though I suppose it would be better to only >> skip them when building for i686. It looks like we only do this >> rarely (e.g., the =E2=80=9Cicu4c=E2=80=9D package), so maybe it=E2=80=99= s not a big deal. > > I=E2=80=99ll keep that in mind for next time I run into a similar issue. > >> Is there any more info about =E2=80=9Cghc-trifecta=E2=80=9D? The other = two have nice >> comments that tell me that upstream is aware of the problem, and that it >> might be fixed in the future. > > That one is a rather opaque build failure kind of thing related to doctes= ts: > > They fail to build on i686: >=20=20=20=20=20 > doctests: > ByteCodeLink.lookupCE > During interactive linking, GHCi couldn't find the following symbol: > lenszm4zi16zi1zmJLUwQ4zzqmnaKkc25AByaCJ_ControlziLensziTH_makeClass= y_closure > This may be due to you not asking GHCi to load extra object files, > archives or DLLs needed by your current session. Restart GHCi, speci= fying > the missing library using the -L/path/to/object/dir and -lmissinglibn= ame > flags, or simply by naming the relevant files on the GHCi command lin= e. > Alternatively, this link failure might indicate a bug in GHCi. > If you suspect the latter, please send a bug report to: > glasgow-haskell-bugs@haskell.org >=20=20=20=20=20 > Test suite doctests: FAIL > > I spent a bit of time digging, then gave up. That=E2=80=99s no problem. I just wanted to be sure that you looked and di= dn=E2=80=99t see anything obvious. We can investigate it later or it may get fixed upstream. > Thanks for the review. You=E2=80=99re welcome! -- Tim