From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre Neidhardt Subject: Re: Looking for help with packaging a Common Lisp library Date: Sat, 25 Jan 2020 21:04:50 +0100 Message-ID: <878slv9ual.fsf@ambrevar.xyz> References: <87k15fa60q.fsf@ambrevar.xyz> <87muab8qf7.fsf@yamatai> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:49945) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ivRfs-0007s3-7x for guix-devel@gnu.org; Sat, 25 Jan 2020 15:04:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ivRfq-0008GD-KW for guix-devel@gnu.org; Sat, 25 Jan 2020 15:04:55 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:34199) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ivRfq-00084H-EH for guix-devel@gnu.org; Sat, 25 Jan 2020 15:04:54 -0500 In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org Sender: "Guix-devel" To: Konrad Hinsen , Guillaume Le Vaillant , guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Konrad Hinsen writes: > Hi Pierre and Guillaume, > > thanks for your quick help! > > Guillaume Le Vaillant writes: > >> I think the generated '...-sbcl-hdf5-cffi-1.8.18/lib/sbcl/hdf5-cffi.asd' >> file is missing a dependency. It contains ':depends-on ("cffi")', but >> I think it should be ':depends-on ("cffi" "cffi-grovel")', because the > > That was the problem indeed. I patched hdf5-cffi.asd to add :cffi-grovel > to the dependencies, and with that patch everything works fine. > >> We could add all the dependencies declared in the original asd files (by >> 'defsystem-depends-on' and 'depends-on') to the generated asd files with >> the following patch: > > I don't know ASDF and the ASDF build system well enough to comment on > that. All I can say is that in a "standard" SBCL + QuickLisp > environment, it is not necessary to patch hdf5-cffi.asd, so it seems > to be correct as far as I can tell, meaning that it would be nice if it > worked out of the box as well in Guix. The Guix package recreates the .asd file (without the defsystem-depends-on), which is why it worked in Quicklisp but not in Guix. We could merge Guillaume's patch, but first I'd like to make sure that this is not an upstream bug. Isn't cffi-grovel supposed to be added to the :depends-on list instead? =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAl4sn2IACgkQm9z0l6S7 zH+0sgf+Kb0HH0e8dGauxGNfJmuRR9peiNDnR7Rv0Lbbhn7swIKz5ntIgZ1sPW3+ 5+/cwYqTjqhqmpcM41QlqQSC4ZcbBN59VKbkM3C9ledGLNzyXsy1ti7VYp1GdY4d nEzHj+QXJkP1gV/0w5lU8waBtSmSCuP2phz/Lq8GYLp5s0qw9gtVzTe+ja4llmE/ nK0MWwFEHO1ucLdB/drY0XiI8mK6ZN5mcGq5v0kmmQGjIEPcUzQwF8pADzW9ldtX USM8jUnKIx4WzfXQTRYRQhdmsyUMgIsFunr9Dqug2VmwQj1v9036F4CB9irDfFFl g7+RsZKiuFRwh1+vCNnTQKDXbwtIwg== =amEV -----END PGP SIGNATURE----- --=-=-=--