From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2D4XMZPOSl8JVAAA0tVLHw (envelope-from ) for ; Sat, 29 Aug 2020 21:54:27 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id UIf2LJPOSl9YFQAA1q6Kng (envelope-from ) for ; Sat, 29 Aug 2020 21:54:27 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 70733940415 for ; Sat, 29 Aug 2020 21:54:27 +0000 (UTC) Received: from localhost ([::1]:52568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kC8nq-0000WW-CS for larch@yhetil.org; Sat, 29 Aug 2020 17:54:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49790) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kC8ni-0000WC-Oi for guix-devel@gnu.org; Sat, 29 Aug 2020 17:54:18 -0400 Received: from world.peace.net ([64.112.178.59]:54458) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kC8ng-0000V2-Pr; Sat, 29 Aug 2020 17:54:18 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kC8ne-0002VE-1l; Sat, 29 Aug 2020 17:54:14 -0400 From: Mark H Weaver To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#42738] [PATCH v4] gnu: emacs: Update to 27.1. In-Reply-To: <87sgc5lpzc.fsf@gnu.org> References: <20200819040941.32696-1-jackhill@jackhill.us> <87sgc6onvi.fsf@gnu.org> <87h7smd7t1.fsf@gnu.org> <87zh6esmi7.fsf@gnu.org> <87imd2bkot.fsf@netris.org> <87sgc5lpzc.fsf@gnu.org> Date: Sat, 29 Aug 2020 17:53:06 -0400 Message-ID: <878sdxm84i.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=64.112.178.59; envelope-from=mhw@netris.org; helo=world.peace.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/29 16:37:03 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org, Amin Bandali Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: 4RlZRILBn2qZ Hi Ludovic, Ludovic Court=C3=A8s wrote: > Mark H Weaver skribis: > >> (define-public emacs-next >> (let ((commit "c36c5a3dedbb2e0349be1b6c3b7567ea7b594f1c") >> (revision "0") >> (emacs-version "27.0.91")) >> (package >> (inherit emacs) >> (name "emacs-next") >> (version (git-version emacs-version revision commit)) >> (source >> (origin >> (inherit (package-source emacs)) >> (method git-fetch) >> (uri (git-reference >> (url "https://git.savannah.gnu.org/git/emacs.git") >> (commit commit))) > > This can be handled with =E2=80=98--with-git-url=E2=80=99. I think that wouldn't work in this case, because we also need to preserve the existing 'patches' and 'snippet' fields, which I arranged to inherit above via (inherit (package-source emacs)). That probably deserves a comment, since it's easily overlooked. >> (sha256 >> (base32 "0mlrg2npy1r79laahkgzhxd1qassfcdz8qk1cpw7mqgf6y5x505h"= )) >> (file-name (git-file-name name version)))) >> (native-inputs >> `(("autoconf" ,autoconf) ; needed when building from trunk >> ,@(package-native-inputs emacs))) > > For this, we=E2=80=99d need a new =E2=80=98--with-extra-input=E2=80=99 pa= ckage transformation > option or similar. That way, we wouldn=E2=80=99t even need an =E2=80=98e= macs-next=E2=80=99 > package: people would just run > > guix install emacs --with-git-url=3D=E2=80=A6 --with-extra-input=3Dauto= conf There's also the 'native-search-paths' field, which cannot simply be inherited because of the version number embedded within EMACSLOADPATH. This particular issue could be avoided if the 'native-search-paths' field were a function of the version number, but that raises migration issues and I'm not sure it's worth it. What do you think? Best regards, Mark