From: "Ludovic Courtès" <ludo@gnu.org>
To: "Antoine R. Dumont (@ardumont)" <antoine.romain.dumont@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: File search
Date: Tue, 06 Dec 2022 11:01:58 +0100 [thread overview]
Message-ID: <878rjkn949.fsf@gnu.org> (raw)
In-Reply-To: <877cz7qg80.fsf@gmail.com> (Antoine R. Dumont's message of "Sun, 04 Dec 2022 17:35:43 +0100")
Howdy!
"Antoine R. Dumont (@ardumont)" <antoine.romain.dumont@gmail.com>
skribis:
> Please, find enclosed the latest implementation as a patch (somewhat vcs
> code ;). I've edited commits to mark Ludo as author with his
> started/amended implementations first [0] (that should be in the patch).
Nice!
> For information, I extracted some number from runs to compare our
> iterations (see the org-file attachment). The first iteration being
> "extracts packages from the store" and the second one "extracts packages
> from the system manifest". Those runs happened both on a guixified
> debian host and a raw guix host (more packages).
So we went from 413s to 11s (on the Guix System node) for only 6% fewer
files in the latter case? Do I get that right? That’s pretty cool.
The implementation based on manifests can of course miss packages, so
it’s a tradeoff. Purely local indexing will only find packages you
already have anyway, so eventually we’ll need a second mode that would
download a database.
BTW, I noticed outputs are not properly handled so far, as in this
example:
--8<---------------cut here---------------start------------->8---
$ GUIX_EXTENSIONS_PATH=$HOME/tmp/guix-index guix index search git-send-email
git@2.38.1 /gnu/store/g3lgyzr749l76qma7srycclgsm0f78iq-git-2.38.1-send-email/libexec/git-core/git-send-email
git@2.37.1 /gnu/store/n3hkzz5ydm0qm1c2jja2pwy2v19mq1k0-git-2.37.1-send-email/libexec/git-core/git-send-email
--8<---------------cut here---------------end--------------->8---
It should instead show “git@2.38.1:send-email”. We probably need an
‘output’ field in the ‘Packages’ table.
Also going forward we’ll need a schema version, as in:
--8<---------------cut here---------------start------------->8---
create table SchemaVersion (
version integer not null;
);
--8<---------------cut here---------------end--------------->8---
so that the tool can upgrade or discard databases that have the wrong
version.
Oh, and progress bars too. And a pony. :-)
Thanks for your work!
Ludo’.
next prev parent reply other threads:[~2022-12-06 10:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 17:58 File search antoine.romain.dumont
2022-12-02 18:22 ` Antoine R. Dumont (@ardumont)
2022-12-03 18:19 ` Ludovic Courtès
2022-12-04 16:35 ` Antoine R. Dumont (@ardumont)
2022-12-06 10:01 ` Ludovic Courtès [this message]
2022-12-06 12:59 ` zimoun
2022-12-06 18:27 ` (
2022-12-08 15:41 ` Ludovic Courtès
2022-12-09 10:05 ` Antoine R. Dumont (@ardumont)
2022-12-09 18:05 ` zimoun
2022-12-11 10:22 ` Ludovic Courtès
2022-12-15 17:03 ` Antoine R. Dumont (@ardumont)
2022-12-19 21:25 ` Ludovic Courtès
2022-12-19 22:44 ` zimoun
2022-12-20 11:13 ` Antoine R. Dumont (@ardumont)
-- strict thread matches above, loose matches on Subject: below --
2022-01-21 9:03 Ludovic Courtès
2022-01-21 10:35 ` Mathieu Othacehe
2022-01-22 0:35 ` Ludovic Courtès
2022-01-21 19:00 ` Vagrant Cascadian
2022-01-22 0:37 ` Ludovic Courtès
2022-01-22 2:53 ` Maxim Cournoyer
2022-01-25 11:15 ` Ludovic Courtès
2022-01-25 11:20 ` Oliver Propst
2022-01-25 11:22 ` Oliver Propst
2022-01-22 4:46 ` raingloom
2022-01-22 7:55 ` Ricardo Wurmus
2022-01-24 15:48 ` Ludovic Courtès
2022-01-24 17:03 ` Ricardo Wurmus
2022-02-02 16:14 ` Maxim Cournoyer
2022-02-05 11:15 ` Ludovic Courtès
2022-01-25 23:45 ` Ryan Prior
2022-02-05 11:18 ` Ludovic Courtès
2022-02-06 13:27 ` André A. Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rjkn949.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=antoine.romain.dumont@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).