From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:1008:1e59::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id qE/kGZrNnWVLFAEAkFu2QA (envelope-from ) for ; Tue, 09 Jan 2024 23:50:02 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id SMvwFJrNnWUAfQAA62LTzQ (envelope-from ) for ; Tue, 09 Jan 2024 23:50:02 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=qHmn3atb; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1704840602; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=i4DC6MZkfkfa5p5AquKhxM9kXrk38xVldTc40BUXH5M=; b=KhAbGPdcS22QWAlpAni1f423b4I5I+H2cNzcOR2/6foZiGn+6qCWMeaUWLZu9eoNyGRZEt mTGsk/Y4m54HjHg7Gkd6UmisArmHavIjArv5ZYX4ZKtd/wfsI+UEIjpPD5EZOs2mwYcIw5 iKkNtD56Pa5xx3TYpuOr9R3cX/PBJBg3mO81BvtQ3CeD1ZeURG5Ryc3/XjXDQxH/tlT43k 2Cx84UrbFsyBz95ug9L/1Q4d//L2DHXiueISbCSOPDsa3nrSKx92qepzPqanKIy6/e0TaX 6i8dpQ4qwqV3r+ul+eif7SURAKBQHxpRs4kFl1VOa1n+moXfWogLe7Duky5wXA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1704840602; a=rsa-sha256; cv=none; b=VLlaf6cGNBWivy7SfipgVe2GfLL02m6R6G5a1g4w1OK0lF00XF5j6haaaf6hmflNlYaP7U 37VCjwECyyFhKoX5DEQCEzPkhvDCzTtuWnN24WJHeEUzl6lg3zukrFoQWNI70xwh7VW/Jz 03JftknQ40llMWW3nxq78FDX/owyp2UltNOT8R468mwn1YDEBSM7LqGQm9Is2cHGI+BDYp f4HuGUfou1VNf+USAHJ+sX+ccQZBOH/elR8PpUkhQDRbbDQdWZS+3nL3kzwsbT8C0uz+8A oonw7E8YDeAJ9bOwSQf3fKqVn0XestO32OE2SeuGySlUe0G3+SAFXFsuaImZ4Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=qHmn3atb; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 33F7F3A33C for ; Tue, 9 Jan 2024 23:50:01 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNKuk-0007XQ-PB; Tue, 09 Jan 2024 17:49:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNKuj-0007Wy-5L for guix-devel@gnu.org; Tue, 09 Jan 2024 17:49:41 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNKug-0005Yk-R9 for guix-devel@gnu.org; Tue, 09 Jan 2024 17:49:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=i4DC6MZkfkfa5p5AquKhxM9kXrk38xVldTc40BUXH5M=; b=qHmn3atbPj88zv9LzAtO LKmhUZ91zQubtkKLXIqPaoIVNFbGzM6BqKIi6FkYcfhGfQ90bdvdZnrWhzuBd5NrjwI7Ryg8OGkxj 3bXgEalAr9yEcAh9raswT3Ttsr5PWAGUZIsJUAsMclGeXrcbEh7Xh8h2zWZAt83oL/fcGqX7zTdiN V9Lt23r/XFC6H/TOIN5Vm6f1WGEd2CuhbRgqEoQho7KMw/tYKQHNFZZm2XTr8Bo6RDvdtdZMzVv6A R+JxRoQVfNufZxD2TZ28HohVWMEZ04UkFIGEvjPYm1wfWK8iN8LpGpz0h8QdgRTLpIzz/P97JLbIE gAm/wrTDSxqnZA==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: guix-devel@gnu.org Subject: Re: #:modules and #:imported-modules, and more In-Reply-To: (Tomas Volf's message of "Sat, 30 Dec 2023 13:54:59 +0100") References: X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: =?utf-8?Q?D=C3=A9cadi?= 20 =?utf-8?Q?Niv=C3=B4se?= an 232 de la =?utf-8?Q?R=C3=A9volution=2C?= jour du Van X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 09 Jan 2024 23:49:33 +0100 Message-ID: <878r4yxgua.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -9.46 X-Spam-Score: -9.46 X-Migadu-Queue-Id: 33F7F3A33C X-Migadu-Scanner: mx11.migadu.com X-TUID: 03RP7NRLc7xh Hello! Tomas Volf <~@wolfsden.cz> skribis: > As seen in the example above, currently there is a need to manually > merge the list of additional modules with the original one. Failing > to use the correct base can lead to issues (like crash in netsurf). > > I would like to propose adding two new fields into the build system, > `#:extra-modules' and `#:extra-imported-modules'. Those would be > automatically appended to the `#:modules' and `#:imported-modules', > removing the need to merge the lists in the package definition. > Therefore the example above would turn into: As a rule of thumb, I personally always avoid the #:extra-things pattern, instead letting users pass #:things in their entirety and documenting the default value. I believe (1) this is clearer (when I see =E2=80=9Cextra=E2=80=9D, I=E2=80= =99m always like =E2=80=9Cextra compared to what?=E2=80=9D), and (2) it gives more control over the things = in question (since one can also remove stuff from the default value). So yes, that=E2=80=99s a bit more boilerplate when all you want is import o= ne additional module, but I think it=E2=80=99s overall a better interface than #:extra. I hope this makes sense! Ludo=E2=80=99.