From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Attila Lendvai <attila@lendvai.name>
Cc: "Ludovic Courtès" <ludo@gnu.org>, guix-devel <guix-devel@gnu.org>
Subject: Re: [shepherd] several patches that i deem ready
Date: Sun, 21 Jan 2024 12:49:14 -0500 [thread overview]
Message-ID: <878r4ia86d.fsf@gmail.com> (raw)
In-Reply-To: <nxELUBe5rliKbhN3hSuR7xxylKPCMLkn379nmym9fQxq0zNUMxZDH01v58_FlkZPXjWKB_lSWXrLwPBOQQuz0MtvOLss0UvDXKakYI0opnI=@lendvai.name> (Attila Lendvai's message of "Sun, 21 Jan 2024 09:38:40 +0000")
Hi Attila,
Attila Lendvai <attila@lendvai.name> writes:
>> - a lightweight logging infrastructure together with plenty of log
>> lines throughout the codebase, and some hints in the README on how
>> to turn log lines gray in emacs (i.e. easily ignorable).
Are you using guile-lib's logging library for it? I've used it in
guile-hall if you want to have an example. We should maximize its
users, refine it and aim to have it builtin Guile at some point.
>
> a quick note on the log statements: they are essentially noise when it
> comes to reading the code, hence the gray coloring i suggest in
> emacs. (although they may often serve also as "executable" comments).
>
> i'd also like to propose to relax the 80 column limit for log lines
> for the same reason that i've explained above.
I don't think an exception is deserved here; the logging library from
guile-lib for example concatenates message strings by default, which
makes it easy to brake long messages on multiple lines.
--
Thanks,
Maxim
next prev parent reply other threads:[~2024-01-21 17:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 23:38 [shepherd] several patches that i deem ready Attila Lendvai
2024-01-21 9:38 ` Attila Lendvai
2024-01-21 17:49 ` Maxim Cournoyer [this message]
2024-01-22 18:38 ` Attila Lendvai
2024-01-23 13:21 ` Maxim Cournoyer
2024-01-24 10:56 ` Attila Lendvai
2024-01-24 13:56 ` Maxim Cournoyer
2024-01-24 16:41 ` Zheng Junjie
2024-01-24 19:23 ` Maxim Cournoyer
2024-01-24 17:11 ` Attila Lendvai
2024-01-26 9:50 ` [OT: s/Joshua/Josiah/ in sig ;-] " bokr
2024-01-26 21:50 ` [OT: s/Joshua/Josiah/ in sig ; -] " Attila Lendvai
2024-04-02 10:43 ` Attila Lendvai
2024-04-10 16:32 ` Ludovic Courtès
2024-04-18 12:15 ` Attila Lendvai
2024-05-23 17:48 ` Attila Lendvai
2024-05-24 16:57 ` Attila Lendvai
2024-05-26 19:02 ` Attila Lendvai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r4ia86d.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=attila@lendvai.name \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).