From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikita Karetnikov Subject: Re: [PATCH] guix package: Add '--delete-generations'. Date: Mon, 23 Sep 2013 14:11:33 +0400 Message-ID: <877ge7onje.fsf@karetnikov.org> References: <87vc2o4qwc.fsf@gnu.org> <87y57kljro.fsf@karetnikov.org> <87hae81uvo.fsf@gnu.org> <87li2oslzh.fsf_-_@karetnikov.org> <878uyo60gp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46992) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VO32a-0003ZS-VR for guix-devel@gnu.org; Mon, 23 Sep 2013 06:06:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VO32Z-0004sZ-Qv for guix-devel@gnu.org; Mon, 23 Sep 2013 06:06:52 -0400 In-Reply-To: <878uyo60gp.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Sun, 22 Sep 2013 22:55:02 +0200") List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable > =E2=80=9CDelete the generations matching @var{patterns} or ... when omitt= ed.=E2=80=9D > Or what actually? I would expect it to delete all the generations but > the current one when PATTERN is omitted, right? =E2=80=98--delete-generations=E2=80=99 deletes everything and points the pr= ofile to the zeroth generation. There are range patterns if you want to keep the current generation. I prefer the current behavior. > Ideally this factorization would go in a patch of its own, before the > one that adds --delete-generations. Is that doable for you? I think so. > No need for =E2=80=98begin=E2=80=99 in the body of a =E2=80=98cond=E2=80= =99 clause. Why? Is it specified somewhere? Or is it easier to read? > Why is there this big hunk? If it=E2=80=99s just reindenting, could you = arrange > to remove this hunk? I couldn=E2=80=99t avoid reindenting since the word =E2=80=9Ccond=E2=80=9D = is longer than =E2=80=9Cif.=E2=80=9D However, I used this opportunity to move a couple of things around. I=E2= =80=99d prefer to keep this change. Frankly, I think that the module should be reorganized at some point (especially the =E2=80=98guix-package=E2=80=99 function). I don=E2=80=99t = like that functions don=E2=80=99t fit on the screen. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBAgAGBQJSQBPYAAoJEM+IQzI9IQ38quMP/0r9qM3XYePKLUWpjFMVgDmI 9IS4QLJoQjje+td/UwvAOWR+6YukwVHk8AxATPFp/wf14PnmquEFLK4eQXNMko8U pKTc0dsGihRjMNTwvgee+0qWVfqpmSQp35+CkxnmR4V/6a8MNcWc/WeABBQ0cs2r 4z4bf1oUaDda3/OURiSasaX7VSFpHsI7pCAQqxwckXMcuyBQJmU4XviaGToCfvtR pQZfPLwO7ygKfqx1FMxRaDTMrtfid86jOg3dTQD+KzDv5NbjZUTFeVCMSbeR7sad qbhnnzBgnMQEc6fHcl3XmhSByHQCF6t3ogs8bRY2SYngc9phUioQizf4Olhut5ii 6V22fvQtiIMlfC9xWI193vW6CqUuuQ8yByYQtF+yaea8Gp+Sa55CCYEZXxPUsTp2 eLtMdq+sXeW5eDK2wrDmEXbh4YvnLSy9Bb/Saxc6rsL0U+f9lgQgC+JYoE9bguHW EQyUCFErvg7rorxR+AzKfev+JbNsg9l9JyQ3qqRELN3NZfIrkNtjIrqZODq3QJJL 2ZPt8TX2WT09gNtWj3nPMD9GGv0KgWB4hb9th/+GkadPMPVPiPNdY4HwP8KzKtlo H67pT8YbnWhhSnxiwfvzYWNPx2QpFfPOfSUqZM+zUms6ob4Z8MiZrYZBTWnQcGGR OvafiWG/BPBfZZSfy3tC =QYhC -----END PGP SIGNATURE----- --=-=-=--