> “Delete the generations matching @var{patterns} or ... when omitted.” > Or what actually? I would expect it to delete all the generations but > the current one when PATTERN is omitted, right? ‘--delete-generations’ deletes everything and points the profile to the zeroth generation. There are range patterns if you want to keep the current generation. I prefer the current behavior. > Ideally this factorization would go in a patch of its own, before the > one that adds --delete-generations. Is that doable for you? I think so. > No need for ‘begin’ in the body of a ‘cond’ clause. Why? Is it specified somewhere? Or is it easier to read? > Why is there this big hunk? If it’s just reindenting, could you arrange > to remove this hunk? I couldn’t avoid reindenting since the word “cond” is longer than “if.” However, I used this opportunity to move a couple of things around. I’d prefer to keep this change. Frankly, I think that the module should be reorganized at some point (especially the ‘guix-package’ function). I don’t like that functions don’t fit on the screen.