From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: Add Package FTGL Date: Sat, 28 Sep 2013 17:23:36 +0200 Message-ID: <877ge1m0lj.fsf@gnu.org> References: <1380381098.864.35.camel@battlestallion> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([208.118.235.92]:51481) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPwRp-000214-2d for guix-devel@gnu.org; Sat, 28 Sep 2013 11:28:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VPwRj-00048U-OW for guix-devel@gnu.org; Sat, 28 Sep 2013 11:28:45 -0400 Received: from hera.aquilenet.fr ([141.255.128.1]:43958) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPwRj-00048K-Dg for guix-devel@gnu.org; Sat, 28 Sep 2013 11:28:39 -0400 In-Reply-To: <1380381098.864.35.camel@battlestallion> (Joshua S. Grant's message of "Sat, 28 Sep 2013 10:11:38 -0500") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: "Joshua \"Youlysses\" S. Grant" Cc: guix-devel@gnu.org Hi! I can=E2=80=99t build it because it depends on freeglut, on your message ab= out freeglut hasn=E2=80=99t yet reached the mailing list. So, initial comments inline below: "Joshua \"Youlysses\" S. Grant" skribis: > ;;; GNU Guix --- Functional package management for GNU > ;;; Copyright =C2=A9 2013 Ludovic Court=C3=A8s This is wrong. :-) > (define-module (gnu packages ftgl) > #:use-module (guix licenses) > #:use-module (guix packages) > #:use-module (guix download) > #:use-module (guix build-system gnu) > #:use-module (gnu packages) > #:use-module (gnu packages xorg) > #:use-module (gnu packages fontutils) ;;The licenses module calls free= type (and it warns me), but dosen't seem to work without explicitly called = as an input. To address that, use a #:renamer (to rename one of the conflicting bindings) or #:select (to select the one you want). Grep the other packages for examples. > (define-public ftgl ;Should expression move to fontutils, xorg, or keep h= ere? Or maybe we could have gl.scm, which would contain freeglut, glu, ftgl, and all that? > (package > (name "ftgl") > (version "2.1.3-rc5")=20 > (source (origin > (method url-fetch) > (uri (string-append "mirror://sourceforge/project/ftgl/FTGL%20Sour= ce/2.1.3~rc5/ftgl-" > version ".tar.gz")) > (sha256 > (base32 "0nsn4s6vnv5xcgxcw6q031amvh2zfj2smy1r5mbnjj2548hxcn2l"))= )) > (build-system gnu-build-system) > (inputs `(("freetype" ,freetype) > ("libx11" ,libx11) > ("mesa" ,mesa) > ("glu" ,glu)))=20 > (home-page "http://sourceforge.net/apps/mediawiki/ftgl/index.php?title= =3DMain_Page")=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20 http://ftgl.sourceforge.net maybe? > (synopsis "A font rendering library for OpenGL applications. ") Rather: =E2=80=9CFont rendering library for OpenGL applications=E2=80=9D (t= hat is: no =E2=80=9CA=E2=80=9D, and no period.) > (description=20 > "FTGL is a font rendering library for OpenGL applications. Supported r= endering modes are: > Bitmaps, Anti-aliased pixmaps, Texture maps, Outlines, Polygon= meshes, and Extruded polygon meshes") > (license lgpl2.0))) ;Mit or Lgpl at your option, not sure how, o= r if one can currently dual-license. If it=E2=80=99s LGPL version 2.0 *or later*, make sure to use =E2=80=98lgpl= 2.0+=E2=80=99. Overall this looks like a good start! Indentation is wrong: please check =E2=80=98Coding Style=E2=80=99 in the =E2=80=98HACKING=E2=80=99 file = and/or existing package definitions in the other files. Thanks! Ludo=E2=80=99.