unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: "Joshua \"Youlysses\" S. Grant" <youlysses@riseup.net>
Cc: guix-devel@gnu.org
Subject: Re: Add Package FTGL
Date: Sat, 28 Sep 2013 17:23:36 +0200	[thread overview]
Message-ID: <877ge1m0lj.fsf@gnu.org> (raw)
In-Reply-To: <1380381098.864.35.camel@battlestallion> (Joshua S. Grant's message of "Sat, 28 Sep 2013 10:11:38 -0500")

Hi!

I can’t build it because it depends on freeglut, on your message about
freeglut hasn’t yet reached the mailing list.

So, initial comments inline below:

"Joshua \"Youlysses\" S. Grant" <youlysses@riseup.net> skribis:

> ;;; GNU Guix --- Functional package management for GNU
> ;;; Copyright © 2013 Ludovic Courtès <ludo@gnu.org>

This is wrong.  :-)

> (define-module (gnu packages ftgl)
>    #:use-module (guix licenses)
>    #:use-module (guix packages)
>    #:use-module (guix download)
>    #:use-module (guix build-system gnu)
>    #:use-module (gnu packages)
>    #:use-module (gnu packages xorg)
>    #:use-module (gnu packages fontutils) ;;The licenses module calls freetype (and it warns me), but dosen't seem to work without explicitly called as an input.

To address that, use a #:renamer (to rename one of the conflicting
bindings) or #:select (to select the one you want).  Grep the other
packages for examples.

> (define-public ftgl ;Should expression move to fontutils, xorg, or keep here?

Or maybe we could have gl.scm, which would contain freeglut, glu, ftgl,
and all that?

>   (package
>      (name "ftgl")
>      (version "2.1.3-rc5") 
>      (source (origin
> 	      (method url-fetch)
> 	      (uri (string-append "mirror://sourceforge/project/ftgl/FTGL%20Source/2.1.3~rc5/ftgl-"
>                                    version ".tar.gz"))
>               (sha256
> 	        (base32 "0nsn4s6vnv5xcgxcw6q031amvh2zfj2smy1r5mbnjj2548hxcn2l"))))
>          (build-system gnu-build-system)
>          (inputs `(("freetype" ,freetype)
>                    ("libx11" ,libx11)
>                    ("mesa" ,mesa)
>                    ("glu" ,glu))) 
> 	 (home-page "http://sourceforge.net/apps/mediawiki/ftgl/index.php?title=Main_Page")                              

http://ftgl.sourceforge.net maybe?

>          (synopsis "A font rendering library for OpenGL applications. ")

Rather: “Font rendering library for OpenGL applications” (that is: no
“A”, and no period.)

>          (description 
> 	  "FTGL is a font rendering library for OpenGL applications. Supported rendering modes are:
>            Bitmaps, Anti-aliased pixmaps, Texture maps, Outlines, Polygon meshes, and Extruded polygon meshes")
>          (license lgpl2.0))) ;Mit or Lgpl at your option, not sure how, or if one can currently dual-license.

If it’s LGPL version 2.0 *or later*, make sure to use ‘lgpl2.0+’.

Overall this looks like a good start!  Indentation is wrong: please
check ‘Coding Style’ in the ‘HACKING’ file and/or existing package
definitions in the other files.

Thanks!

Ludo’.

       reply	other threads:[~2013-09-28 15:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1380381098.864.35.camel@battlestallion>
2013-09-28 15:23 ` Ludovic Courtès [this message]
2013-09-28 15:07 Add Package FTGL Joshua "Youlysses" S. Grant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877ge1m0lj.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=youlysses@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).