From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: Add httpd Date: Sun, 29 Sep 2013 19:19:29 +0200 Message-ID: <877gdzilzy.fsf@gnu.org> References: <1380465751.25677.5.camel@creek.rivers> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQKjZ-0002AN-Ce for guix-devel@gnu.org; Sun, 29 Sep 2013 13:24:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VQKjQ-0006EZ-9U for guix-devel@gnu.org; Sun, 29 Sep 2013 13:24:41 -0400 Received: from hera.aquilenet.fr ([141.255.128.1]:45738) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VQKjQ-0006EE-3F for guix-devel@gnu.org; Sun, 29 Sep 2013 13:24:32 -0400 In-Reply-To: <1380465751.25677.5.camel@creek.rivers> (Aljosha Papsch's message of "Sun, 29 Sep 2013 16:42:31 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Aljosha Papsch Cc: guix-devel@gnu.org Hi, Thanks for joining the hackathon! Aljosha Papsch skribis: > attached is a patch for Apache httpd. I named the module web, so other > web servers might go in there (maybe merge in libmicrohttpd?). Yes, makes sense. > I hope the format is alright. It's just the output of git format-patch. It=E2=80=99s good overall. Just a couple of minor suggestions in-line, and= then we can commit it: > From a54ae468ab008bad21e5d1069ee36a0eaa0ee40a Mon Sep 17 00:00:00 2001 > From: Aljosha Papsch > Date: Sun, 29 Sep 2013 16:30:19 +0200 > Subject: [PATCH] gnu: Add httpd * gnu/packages/web.scm (httpd): New varia= ble * > gnu-system.am (GNU_SYSTEM_MODULES): Add it Please just write just =E2=80=9CAdd httpd=E2=80=9D in the subject line, and= write the rest of the log in the body, one line per thing. Here=E2=80=99s an example: > +(define-public httpd > + (package > + (name "httpd") > + (version "2.4.6") > + (source (origin > + (method url-fetch) > + (uri (string-append "mirror://apache/httpd/httpd-" > + version ".tar.bz2")) > + (sha256 > + (base32 > + "1sig08xxq1kqxr2a42ndwr9g4mm6zdqnxldhxraym2y0xcjkd7yw")))) Please do not use tabs in .scm files (for Emacs there=E2=80=99s a .dir-loca= ls.el file that should set it up.) > + (arguments > + `(#:tests? #f Usually we try to fix any test suite issues, but sometimes we end up disabling it altogether when that=E2=80=99s really too much effort or when = we=E2=80=99re waiting for feedback from upstream. What problems did you encounter? A typical issue with networking packages is that tests try to perform DNS lookups, which doesn=E2=80=99t wo= rk in our chroot build environment. Often that can be worked around, for instance by replacing =E2=80=98localhost=E2=80=99 with =E2=80=98127.0.0.1= =E2=80=99. > + #:configure-flags (list "--enable-rewrite" > + "--enable-userdir" > + "--enable-vhost-alias" > + "--enable-ssl" > + "--enable-mime-magic" > + (string-append "--sysconfdir=3D" > + (assoc-ref %outputs "out") > + "/etc/httpd")))) > + (synopsis "A robust, commercial-grade, featureful HTTP server") =E2=80=9CFeatureful HTTP server=E2=80=9D should be enough. Thanks! Ludo=E2=80=99.