Re: [PATCH] gnu: Add httpd

[ludo@gnu.org (Ludovic Courtès)]

Hi,

Thanks for joining the hackathon!

Aljosha Papsch <lists@rpapsch.de> skribis:

> attached is a patch for Apache httpd.  I named the module web, so other
> web servers might go in there (maybe merge in libmicrohttpd?).

Yes, makes sense.

> I hope the format is alright. It's just the output of git format-patch.

It’s good overall.  Just a couple of minor suggestions in-line, and then
we can commit it:

> From a54ae468ab008bad21e5d1069ee36a0eaa0ee40a Mon Sep 17 00:00:00 2001
> From: Aljosha Papsch <misc@rpapsch.de>
> Date: Sun, 29 Sep 2013 16:30:19 +0200
> Subject: [PATCH] gnu: Add httpd * gnu/packages/web.scm (httpd): New variable *
>  gnu-system.am (GNU_SYSTEM_MODULES): Add it

Please just write just “Add httpd” in the subject line, and write the
rest of the log in the body, one line per thing.

Here’s an example:

> +(define-public httpd
> +  (package
> +   (name "httpd")
> +   (version "2.4.6")
> +   (source (origin
> +	    (method url-fetch)
> +	    (uri (string-append "mirror://apache/httpd/httpd-"
> +				version ".tar.bz2"))
> +	    (sha256
> +	     (base32
> +	      "1sig08xxq1kqxr2a42ndwr9g4mm6zdqnxldhxraym2y0xcjkd7yw"))))

Please do not use tabs in .scm files (for Emacs there’s a .dir-locals.el
file that should set it up.)

> +   (arguments
> +    `(#:tests? #f

Usually we try to fix any test suite issues, but sometimes we end up
disabling it altogether when that’s really too much effort or when we’re
waiting for feedback from upstream.

What problems did you encounter?  A typical issue with networking
packages is that tests try to perform DNS lookups, which doesn’t work in
our chroot build environment.  Often that can be worked around, for
instance by replacing ‘localhost’ with ‘127.0.0.1’.

> +      #:configure-flags (list "--enable-rewrite"
> +                              "--enable-userdir"
> +                              "--enable-vhost-alias"
> +                              "--enable-ssl"
> +                              "--enable-mime-magic"
> +                              (string-append "--sysconfdir="
> +                                             (assoc-ref %outputs "out")
> +                                             "/etc/httpd"))))
> +   (synopsis "A robust, commercial-grade, featureful HTTP server")

“Featureful HTTP server” should be enough.

Thanks!

Ludo’.