From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: gnunet: Add gnurl-7.34.0.
Date: Wed, 29 Jan 2014 23:13:16 +0100
Message-ID: <877g9ibfnn.fsf@gnu.org>
References: <1391000351-5487-1-git-send-email-sreeharsha@totakura.in>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47985)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1W8dSk-000737-1l
	for guix-devel@gnu.org; Wed, 29 Jan 2014 17:18:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1W8dSe-0000yT-9K
	for guix-devel@gnu.org; Wed, 29 Jan 2014 17:18:25 -0500
Received: from hera.aquilenet.fr ([141.255.128.1]:51518)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1W8dSe-0000yK-1t
	for guix-devel@gnu.org; Wed, 29 Jan 2014 17:18:20 -0500
In-Reply-To: <1391000351-5487-1-git-send-email-sreeharsha@totakura.in> (Sree
	Harsha Totakura's message of "Wed, 29 Jan 2014 13:59:11 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Sree Harsha Totakura <sreeharsha@totakura.in>
Cc: guix-devel@gnu.org

Sree Harsha Totakura <sreeharsha@totakura.in> skribis:

> * gnu/packages/gnunet.scm (gnurl): New variable. Thanks to Zerwas for the=
 initial recipe.

Thanks, applied, with this phase:

> +       (lambda* (#:rest args)
> +         (begin (chdir "tests")
> +                (let* ((path (search-path-as-string->list (getenv "PATH"=
)))
> +                       (sh (search-path path "sh"))
> +                       (exp (string-append "s@/bin/sh@" sh "@g"))
> +                       (f (open-file "data/DISABLED" "a")))
> +                  (system* "sed" "-i" exp "runtests.pl")
> +                  (newline f)
> +                  (display "1022" f)
> +                  (close f))
> +                (chdir "../")))
> +       %standard-phases)))

changed to the more idiomatic (and hopefully more elegant too):

       (lambda _
         (with-directory-excursion "tests"  ; <- like =E2=80=9Ccd tests; ..=
.; cd ..=E2=80=9D
           (substitute* "runtests.pl"       ; <- like sed
             (("/bin/sh")
              (which "sh")))                ; <- like =E2=80=98search-path=
=E2=80=99 etc.
           (let* ((port (open-file "data/DISABLED" "a")))
             (newline port)
             (display "1022" port)
             (close port))))

Ludo=E2=80=99.