From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/2] gnu: Add pip.
Date: Wed, 12 Feb 2014 14:06:08 +0100
Message-ID: <877g9032gv.fsf@gnu.org>
References: <1392159886-17521-1-git-send-email-tipecaml@gmail.com>
	<1392159886-17521-3-git-send-email-tipecaml@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38451)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1WDZW5-0007gg-UX
	for guix-devel@gnu.org; Wed, 12 Feb 2014 08:06:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1WDZVx-0001oI-Gi
	for guix-devel@gnu.org; Wed, 12 Feb 2014 08:06:17 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:43359)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1WDZVx-0001ny-A1
	for guix-devel@gnu.org; Wed, 12 Feb 2014 08:06:09 -0500
In-Reply-To: <1392159886-17521-3-git-send-email-tipecaml@gmail.com> (Cyril
	Roelandt's message of "Wed, 12 Feb 2014 00:04:46 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org

Cyril Roelandt <tipecaml@gmail.com> skribis:

> * gnu/packages/python.scm (python-pip, python2-pip): New variables.

Looks good to me.  One question though:

> +    (arguments
> +     `(#:tests? #f)) ; The tests try to access the Internet.

How hard would it be to either skip the tests that access the network,
or patch them to use localhost instead of some external server?

Thanks,
Ludo=E2=80=99.