From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] import: Add PyPI importer.
Date: Mon, 29 Sep 2014 14:24:57 +0200
Message-ID: <877g0mzk9y.fsf@gnu.org>
References: <8761g8ojde.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
	<8738bcoj77.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
	<874mvsg31g.fsf@gnu.org>
	<87fvfazn4z.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48309)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XYa0p-0008Hm-1C
	for guix-devel@gnu.org; Mon, 29 Sep 2014 08:25:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XYa0k-0001dK-9M
	for guix-devel@gnu.org; Mon, 29 Sep 2014 08:25:06 -0400
Received: from hera.aquilenet.fr ([2a01:474::1]:41150)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1XYa0k-0001Ur-2x
	for guix-devel@gnu.org; Mon, 29 Sep 2014 08:25:02 -0400
In-Reply-To: <87fvfazn4z.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
	(David Thompson's message of "Mon, 29 Sep 2014 07:23:08 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org

David Thompson <dthompson2@worcester.edu> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>
>> David Thompson <dthompson2@worcester.edu> skribis:
>>
>>> I should mention that the PyPI import requires the guile-json library.
>>> How should this be handled in our build scripts?=20
>>
>> I think it=E2=80=99s fine to install it whether or not guile-json is ava=
ilable.
>> Now, when there are tests ;-), there=E2=80=99ll have to be an Automake
>> conditional to decide whether or not to run those tests that require
>> guile-json.
>
> Oh yeah, almost forgot about the Automake rule!  My autotools skills are
> weak so I'm not sure how to write this.  Could you point me in the right
> direction?

In configure.ac, do something like:

  GUILE_MODULE_AVAILABLE([have_guile_json], [(json)])
  AM_CONDITIONAL([HAVE_GUILE_JSON], [text "x$have_guile_json" =3D "xyes"])

and in Makefile.am:

  if HAVE_GUILE_JSON
  TESTS +=3D tests/pypi.scm
  endif

Ludo=E2=80=99.