From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: [PATCH] gnu: Add quvi. Date: Fri, 06 Mar 2015 17:47:26 -0500 Message-ID: <877futlp4x.fsf@netris.org> References: <87385ke82v.fsf@taylan.uni.cx> <20150306215436.GA32174@debian> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40721) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YU11s-0001cL-Jm for guix-devel@gnu.org; Fri, 06 Mar 2015 17:47:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YU11o-0003Kz-1M for guix-devel@gnu.org; Fri, 06 Mar 2015 17:47:36 -0500 Received: from world.peace.net ([50.252.239.5]:55135) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YU11n-0003Ij-T5 for guix-devel@gnu.org; Fri, 06 Mar 2015 17:47:31 -0500 In-Reply-To: <20150306215436.GA32174@debian> (Andreas Enge's message of "Fri, 6 Mar 2015 22:54:36 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andreas Enge Cc: guix-devel@gnu.org Andreas Enge writes: > On Wed, Mar 04, 2015 at 11:00:56PM +0100, Taylan Ulrich Bay=C4=B1rl=C4=B1= /Kammer wrote: >> This actually adds three packages but they're closely tied together. > > Still, could you commit them as three separate packages? I'm familiar with these packages, and I tend to agree that they are so closely tied that it's reasonable to commit them together. >> + (origin >> + (method url-fetch) >> + (uri (string-append >> + "mirror://sourceforge/quvi/libquvi-" version ".tar.xz")) >> + (sha256 >> + (base32 "00x9gbmzc5cns0gnfag0hsphcr3cb33vbbb9s7ppvvd6bxz2z1mm")= ))) > > Your indentation (here and further down) is not quite consistens, sometim= es > it it one, sometimes two spaces. He's using the auto-indenter of Emacs Scheme Mode, which faithfully follows the rules in our .dir-locals.el file. >> + (string-append "liblua_CFLAGS=3D-I" lua "/include") >> + (string-append "liblua_LIBS=3D-L" lua "/libs -llua"))))) > > These are two flags and should be two entries in the list. What Taylan wrote above looks right to me. The -L[...] and -llua are two flags, but the variable setting "liblua_LIBS=3D-L[...]/libs -llua" needs to be one argument to configure. Thanks, Mark