From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>
Subject: Re: [PATCH] gnu: Add adwaita-icon-theme.
Date: Sat, 23 May 2015 11:35:21 +0800
Message-ID: <877fs0neyu.fsf@gmail.com>
References: <1431427501-25929-1-git-send-email-iyzsong@gmail.com>
	<87mw19y2iy.fsf@gnu.org> <87vbfxqnou.fsf@gmail.com>
	<87fv70x660.fsf@gnu.org> <87r3qdvtk1.fsf@gmail.com>
	<87vbfklpm5.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46728)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@gmail.com>) id 1Yw0D1-00059T-PL
	for guix-devel@gnu.org; Fri, 22 May 2015 23:34:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <iyzsong@gmail.com>) id 1Yw0D0-00006g-OA
	for guix-devel@gnu.org; Fri, 22 May 2015 23:34:47 -0400
In-Reply-To: <87vbfklpm5.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

Ludovic Court=C3=A8s <ludo@gnu.org> writes:

> =E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> skribis:
>
>> From ff7e16bc8b7e803d49d5ee880f31f3f4e1660d3c Mon Sep 17 00:00:00 2001
>> From: =3D?UTF-8?q?=3DE5=3DAE=3D8B=3DE6=3D96=3D87=3DE6=3DAD=3DA6?=3D <iyz=
song@gmail.com>
>> Date: Tue, 19 May 2015 16:32:09 +0800
>> Subject: [PATCH 1/2] gnu: gtk+: Add SVG support to 'gtk-encode-symbolic-=
svg'.
>>
>> * gnu/packages/gtk.scm (gtk+)[inputs]: Add librsvg.
>>   [arguments]: Add 'wrap-gtk-encode-symbolic-svg' phase.
>
> [...]
>
>> +        'install 'wrap-gtk-encode-symbolic-svg
>> +        (lambda* (#:key inputs outputs #:allow-other-keys)
>> +          (let* ((out (assoc-ref outputs "out"))
>> +                 (prog (string-append out "/bin/gtk-encode-symbolic-svg=
"))
>> +                 (librsvg (assoc-ref inputs "librsvg"))
>> +                 (loaders.cache (find-files librsvg "^loaders\\.cache$"=
)))
>> +            (wrap-program prog
>> +              `("GDK_PIXBUF_MODULE_FILE" =3D ,loaders.cache))))
>> +        %standard-phases))))))
>
> Could you add a comment there explaining what=E2=80=99s going on?
OK.
>
> So =E2=80=98gtk-encode-symbolic-svg=E2=80=99 uses that loader mechanism, =
which is why it
> doesn=E2=80=99t actually support SVG out-of-the-box, even if librsvg is a=
lready
> an input, right?
Yes.
>
> This would have to be committed in a gtk-rebuild branch.
Done.

Thanks for review!