From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] build: ruby: Add 'gem-flags' key to ruby build system
Date: Sun, 19 Jul 2015 22:44:18 +0200
Message-ID: <877fpvnahp.fsf@gnu.org>
References: <20150713134451.GA29236@thebird.nl> <87380lo5kz.fsf@gnu.org>
	<20150719092941.GA25934@thebird.nl>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47466)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZGvRh-0000Ah-9X
	for guix-devel@gnu.org; Sun, 19 Jul 2015 16:44:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZGvRe-0005lC-1m
	for guix-devel@gnu.org; Sun, 19 Jul 2015 16:44:25 -0400
In-Reply-To: <20150719092941.GA25934@thebird.nl> (Pjotr Prins's message of
	"Sun, 19 Jul 2015 11:29:41 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Pjotr Prins <pjotr.public12@thebird.nl>
Cc: guix-devel <guix-devel@gnu.org>

Pjotr Prins <pjotr.public12@thebird.nl> skribis:

> On Sat, Jul 18, 2015 at 05:20:28PM +0200, Ludovic Court=C3=A8s wrote:
>> >      (zero? (system* "gem" "install" "--local"
>> > -                    "--bindir" (string-append out "/bin")))))
>> > +                    "--bindir" (string-append out "/bin") "--"
>> > +                    (string-join (cond (null? gem-flags)('())(gem-fla=
gs)))))))
>>=20
>> , and =E2=80=98gem-flags=E2=80=99 is not a procedure so it cannot be cal=
led.  So
>> I=E2=80=99ve changed that, also removing the =E2=80=9C--=E2=80=9D.  Push=
ed as 6e9f291.
>
> The "--" is required when gem-flags is passed in. It is optional when
> gem-flags is empty. Do you think gem authors should always prepend the
> "--" in front of the other options? I would think it is a builder
> thing if we can abstract it away. Right? If that is so, we can leave it
> there since it is harmless if gem-flags is empty.

My guess is that there are options like --bindir (maybe =E2=80=9C--docdir=
=E2=80=9D?) for
which =E2=80=9C--=E2=80=9D does not need to be added, and others for which =
it is
needed.  That=E2=80=99s why I left it out (also: users can easily add =E2=
=80=9C--=E2=80=9D but
cannot remove it if it=E2=80=99s hard-coded.)

Now, Dave and you definitely know this better than me, so I=E2=80=99ll rely=
 on
your judgment.  Thoughts?

Ludo=E2=80=99.