From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: "M-x guix" - magit-like interface for guix commands Date: Fri, 28 Aug 2015 23:08:13 +0300 Message-ID: <877fof41n6.fsf@gmail.com> References: <87zj1u704r.fsf@gmail.com> <87h9nngjfh.fsf@gnu.org> <87y4gywbrz.fsf@gmail.com> <871tenu51t.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49911) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVPwg-0002zR-RY for guix-devel@gnu.org; Fri, 28 Aug 2015 16:08:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZVPwa-0003v9-Mu for guix-devel@gnu.org; Fri, 28 Aug 2015 16:08:18 -0400 In-Reply-To: <871tenu51t.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Fri, 28 Aug 2015 11:37:50 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org Ludovic Court=C3=A8s (2015-08-28 12:37 +0300) wrote: > Alex Kost skribis: > >> Ludovic Court=C3=A8s (2015-08-26 00:14 +0300) wrote: >> >>> Alex Kost skribis: >>> >>>> Hello, I've pushed 'wip-emacs-popup-ui' branch with emacs magit-like >>>> (popup) interface for guix commands. >>> >>> BTW I=E2=80=99ve quickly looked at the commits and don=E2=80=99t have a= ny comments. >>> Feel free to merge to master when you deem appropriate. >> >> Ouch, sounds like a carte-blanche. > > Of course, you=E2=80=99re effectively the maintainer of that part. OK, but I also made some changes outside "emacs" dir: - I exported stuff from (guix scripts lint) and (guix scripts graph): so that when a user choose "--checkers" option for 'guix lint' or "--type" option for 'guix graph', they can be completed while prompted in minibuffer. - I moved emacs info node from "Package Management" to "Top" because it is not just about package management anymore (as there are "guix-prettify" and shell completions, and now there is also popup interface for all guix commands). - And finally I moved a part of code from 'guix-main' to a new 'run-guix' procedure (in (guix ui) module). As for the emacs part: many long options don't have short analogs, so I chose keys (for popup windows) that seem appropriate for me, but they may not be good defaults for others. The same thing with guix commands. For example, I chose "p" for "package", "P" for "pull" and "u" for "publish"; or "s" for "system" and "z" for "size", etc. But maybe it is OK for now, and may be fixed later, if people will complain about strange popup keys, WDYT? Also perhaps there are too many auxiliary commits (add this, add that), not sure if it's acceptable. >> IMO this feature is ready, at least I've been successfully using it for >> a couple of weeks. But I think that we should have a new Magit2 package >> at first. So I'm going to add this feature to master after pushing the >> following patches if you don't mind: >> >> http://lists.gnu.org/archive/html/guix-devel/2015-08/msg00571.html >> http://lists.gnu.org/archive/html/guix-devel/2015-08/msg00383.html >> http://lists.gnu.org/archive/html/guix-devel/2015-08/msg00433.html > > So I guess you can now go ahead. Yes, I think so. I have rebased "wip-emacs-popup-ui" branch on master and made some final tweaks. So this is the last warning! :-) If you still don't have comments/notes, I'm ready to push these commits. --=20 Alex