From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mathieu Lirzin <mthl@openmailbox.org>
Subject: Re: [PATCH 3/4] gnu: Add python-webob.
Date: Tue, 15 Sep 2015 18:43:39 +0200
Message-ID: <877fnrab0k.fsf@openmailbox.org>
References: <1442265803-26218-1-git-send-email-tipecaml@gmail.com>
	<1442265803-26218-4-git-send-email-tipecaml@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38925)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mthl@openmailbox.org>) id 1ZbtKp-0000I8-Py
	for guix-devel@gnu.org; Tue, 15 Sep 2015 12:44:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mthl@openmailbox.org>) id 1ZbtKm-0005JH-J3
	for guix-devel@gnu.org; Tue, 15 Sep 2015 12:43:59 -0400
Received: from smtp26.openmailbox.org ([62.4.1.60]:57436)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mthl@openmailbox.org>) id 1ZbtKm-0005Iz-9s
	for guix-devel@gnu.org; Tue, 15 Sep 2015 12:43:56 -0400
In-Reply-To: <1442265803-26218-4-git-send-email-tipecaml@gmail.com> (Cyril
	Roelandt's message of "Mon, 14 Sep 2015 23:23:22 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org

Cyril Roelandt <tipecaml@gmail.com> writes:

> * gnu/packages/python.scm (python-webob, python2-webob): New variables.
> ---
>  gnu/packages/python.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index c58d7f3..919573f 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -4853,3 +4853,30 @@ fractional seconds) of a clock which never goes backwards.")
>  
>  (define-public python2-monotonic
>    (package-with-python2 python-monotonic))
> +
> +(define-public python-webob
> +  (package
> +    (name "python-WebOb")
                     ^^^
Does these uppercase letters are required?

> +    (version "1.5.0b0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://pypi.python.org/packages/source/W/WebOb/WebOb-"
> +             version ".tar.gz"))
> +       (sha256
> +         (base32
> +          "140b3iczclk1j0405rvw5gxshqfkhcc8254fj520z3m23cwbql4a"))))

   (sha256
    (base32
     "..."))

> +    (build-system python-build-system)
> +    (inputs
> +      `(("python-nose" ,python-nose)
> +        ("python-setuptools" ,python-setuptools)))
> +    (home-page "http://webob.org/")
> +    (synopsis "WSGI request and response object")
> +    (description
> +      "WebOb provides wrappers around the WSGI request environment, and an
> +object to help create WSGI responses.")
> +    (license license:expat)))
> +
> +(define-public python2-webob
> +  (package-with-python2 python-webob))

Otherwise LGTM.

--
Mathieu Lirzin