From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mathieu Lirzin Subject: Re: [PATCH] gnu: Add python-xlrd. Date: Sat, 19 Sep 2015 22:37:16 +0200 Message-ID: <877fnmno1v.fsf@openmailbox.org> References: <55FD6561.8050608@uq.edu.au> <87k2rmflyv.fsf@openmailbox.org> <87si6a5fzf.fsf@mdc-berlin.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49633) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZdOt2-0006To-Lr for guix-devel@gnu.org; Sat, 19 Sep 2015 16:37:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZdOsz-0004rc-FS for guix-devel@gnu.org; Sat, 19 Sep 2015 16:37:32 -0400 Received: from smtp18.openmailbox.org ([62.4.1.52]:49234) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZdOsz-0004rU-6n for guix-devel@gnu.org; Sat, 19 Sep 2015 16:37:29 -0400 In-Reply-To: <87si6a5fzf.fsf@mdc-berlin.de> (Ricardo Wurmus's message of "Sat, 19 Sep 2015 22:08:52 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: "guix-devel@gnu.org" Ricardo Wurmus writes: > Mathieu Lirzin writes: > >>> + ;; so use nose to run tests instead for now. >>> + (replace 'check (lambda _ (zero? (system* "nosetests"))))))) >>> + (native-inputs >>> + `(("python-setuptools" ,python2-setuptools) >>> + ("python-nose" ,python2-nose))) >> >> I don't know python packaging but when I look at other packages it >> seems that these are usually used as =E2=80=9Cinputs=E2=80=9D not >> =E2=80=9Cnative-inputs=E2=80=9D. > > Nose is used for the tests only and setuptools is used at build time, so > I think it=E2=80=99s fine like this. Is this a general statement or something specific to this package? If this is general it seems to be a good idea to make a big commit that fixes all the python packages which use these dependencies as normal inputs? WDYT? -- Mathieu Lirzin