From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCHES] Add love and devil
Date: Mon, 16 Nov 2015 21:55:25 +0100
Message-ID: <877flhoe9u.fsf@elephly.net>
References: <87bnaw2i4n.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35607)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1ZyQoK-0005w4-8U
	for guix-devel@gnu.org; Mon, 16 Nov 2015 15:55:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1ZyQoF-0000ui-A1
	for guix-devel@gnu.org; Mon, 16 Nov 2015 15:55:36 -0500
Received: from sender163-mail.zoho.com ([74.201.84.163]:24995)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1ZyQoF-0000uL-2K
	for guix-devel@gnu.org; Mon, 16 Nov 2015 15:55:31 -0500
In-reply-to: <87bnaw2i4n.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org


David Thompson <dthompson2@worcester.edu> writes:

> Yes, these are real software packages!  LÖVE is a neat game framework
> that uses Lua and depends on DevIL for image loading.

Yay for LÖVE!

> +(define-public devil
> +  (package
> +    (name "devil")

[...]

> +    (arguments
> +     '(#:configure-flags '("--enable-ILUT=yes") ; build utility library
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'check 'fix-tests
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             ;; Fix hard-coded /bin/bash reference.
> +             (substitute* '("test/Makefile")
> +               (("TESTS_ENVIRONMENT = /bin/bash")
> +                (string-append "TESTS_ENVIRONMENT = "
> +                               (assoc-ref inputs "bash")
> +                               "/bin/bash")))
> +             #t)))))

Could this be fixed by passing “TESTS_ENVIRONMENT” as a make-flag
instead?

Otherwise looks good to me (both this and the second patch).
Thank you!

~~ Ricardo