From: Ricardo Wurmus <rekado@elephly.net>
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org
Subject: Re: [PATCHES] Add love and devil
Date: Mon, 16 Nov 2015 21:55:25 +0100 [thread overview]
Message-ID: <877flhoe9u.fsf@elephly.net> (raw)
In-Reply-To: <87bnaw2i4n.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
David Thompson <dthompson2@worcester.edu> writes:
> Yes, these are real software packages! LÖVE is a neat game framework
> that uses Lua and depends on DevIL for image loading.
Yay for LÖVE!
> +(define-public devil
> + (package
> + (name "devil")
[...]
> + (arguments
> + '(#:configure-flags '("--enable-ILUT=yes") ; build utility library
> + #:phases
> + (modify-phases %standard-phases
> + (add-before 'check 'fix-tests
> + (lambda* (#:key inputs #:allow-other-keys)
> + ;; Fix hard-coded /bin/bash reference.
> + (substitute* '("test/Makefile")
> + (("TESTS_ENVIRONMENT = /bin/bash")
> + (string-append "TESTS_ENVIRONMENT = "
> + (assoc-ref inputs "bash")
> + "/bin/bash")))
> + #t)))))
Could this be fixed by passing “TESTS_ENVIRONMENT” as a make-flag
instead?
Otherwise looks good to me (both this and the second patch).
Thank you!
~~ Ricardo
prev parent reply other threads:[~2015-11-16 20:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-15 0:58 [PATCHES] Add love and devil David Thompson
2015-11-16 8:58 ` Ludovic Courtès
2015-11-16 20:55 ` Ricardo Wurmus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877flhoe9u.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=dthompson2@worcester.edu \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).