From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 4/4] gnu: Add gst-python. Date: Mon, 07 Mar 2016 00:20:04 +0100 Message-ID: <877fhfchy3.fsf@gnu.org> References: <1457248078-13098-1-git-send-email-iyzsong@gmail.com> <1457248078-13098-4-git-send-email-iyzsong@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44267) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1achy6-0000Ro-AR for guix-devel@gnu.org; Sun, 06 Mar 2016 18:20:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1achy3-0006uf-58 for guix-devel@gnu.org; Sun, 06 Mar 2016 18:20:10 -0500 In-Reply-To: <1457248078-13098-4-git-send-email-iyzsong@gmail.com> (=?utf-8?B?IuWui+aWh+atpiIncw==?= message of "Sun, 6 Mar 2016 15:07:58 +0800") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: =?utf-8?B?5a6L5paH5q2m?= Cc: guix-devel@gnu.org =E5=AE=8B=E6=96=87=E6=AD=A6 skribis: > * gnu/packages/gstreamer.scm (python-gst, python2-gst): New variables. [...] > + (arguments > + `(#:configure-flags > + (let ((python-sitedir > + ;; XXX: make this a package property? > + ,(string-append "lib/python" > + (version-major+minor (package-version pyth= on)) > + "/site-packages"))) I think the directory name should be computed on the =E2=80=9Cbuild side=E2= =80=9D, possibly using =E2=80=98get-python-version=E2=80=99 from (guix build python-build-system) or something equivalent. That way, =E2=80=98python2-gst=E2=80=99 wouldn=E2=80=99t have to duplicate = this snippet. WDYT? Ludo=E2=80=99.