From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] Add MilkyTracker to Guix Date: Wed, 30 Mar 2016 23:52:04 +0300 Message-ID: <877fgjy9hn.fsf@gmail.com> References: <6dae35698781717e6043be7086b6f63c@openmailbox.org> <20160327072337.GA13339@debian-netbook> <20160327230935.14e8ba5a@openmailbox.org> <87shzayj69.fsf@gmail.com> <87vb46ispl.fsf@elephly.net> <20160328133050.72048b52@openmailbox.org> <20160328133931.4307044a@openmailbox.org> <20160328134320.1e0a50ae@openmailbox.org> <87bn5x7gr2.fsf@gmail.com> <20160329222441.12a28061@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57106) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alN63-0004TO-60 for guix-devel@gnu.org; Wed, 30 Mar 2016 16:52:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alN60-0007yO-EW for guix-devel@gnu.org; Wed, 30 Mar 2016 16:52:11 -0400 Received: from mail-lb0-x22e.google.com ([2a00:1450:4010:c04::22e]:36013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alN60-0007yD-1i for guix-devel@gnu.org; Wed, 30 Mar 2016 16:52:08 -0400 Received: by mail-lb0-x22e.google.com with SMTP id qe11so39652941lbc.3 for ; Wed, 30 Mar 2016 13:52:07 -0700 (PDT) In-Reply-To: <20160329222441.12a28061@openmailbox.org> (Kei Yamashita's message of "Tue, 29 Mar 2016 22:24:41 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Kei Yamashita Cc: guix-devel@gnu.org Kei Yamashita (2016-03-30 05:24 +0300) wrote: > Alright! This patch adds MilkyTracker successfully. It builds with > both ALSA and JACK support. I took a look at the PKGBUILD from Arch > Linux and the port dependencies from FreeBSD to make sure I had > everything in order. Hopefully it is clean as far as syntax and guix > standards go. Great! Thank you for fixing the build process! I have only 4 small comments: 1) Your previous patches contained: + #:use-module (gnu packages sdl) But it is removed in this one. I think it was done by mistake when you removed the leftovers of other commits. > If you could show me how you managed to get guix lint to > run on this file, that would be great. As Leo pointed, you can use "pre-inst-env" script to run guix tools from a git checkout. See (info "(guix) Running Guix Before It Is Installed") for details. > From e3a393da0ee6d0a22d4077a6f83601a8a246def3 Mon Sep 17 00:00:00 2001 > From: Kei Yamashita > Date: Tue, 29 Mar 2016 22:17:21 -0400 > Subject: [PATCH] gnu: Add MilkyTracker. > > * gnu/packages/music.scm (milkytracker): New variable. > --- > gnu/packages/music.scm | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm > index adda16a..9794c17 100644 > --- a/gnu/packages/music.scm > +++ b/gnu/packages/music.scm > @@ -1306,3 +1306,33 @@ once and for all. It catalogs your collection, au= tomatically improving its > metadata as it goes using the MusicBrainz database. Then it provides a = variety > of tools for manipulating and accessing your music.") > (license license:expat))) > + > +(define-public milkytracker > + (package > + (name "milkytracker") > + (version "0.90.86") > + (source (origin > + (method url-fetch) ^^^^ 2) tabulation on this line > + (uri (string-append "http://milkytracker.org/files/" > + name "-" version ".tar.bz2")) > +=20=20=20=20=20=20=20=20=20=20=20=20=20=20 ^^^^^^^^^^^^^^ 3) this redundant line > + (sha256 > + (base32 > + "1v9vp8vi24lkagfpr92c128whvakwgrm9pq2zf6ijpl5sh7014zb"))= )) > + (build-system gnu-build-system) > + (arguments > + `(#:make-flags '("CXXFLAGS=3D-lasound"))) > + (inputs > + `(("alsa-lib" ,alsa-lib) > + ("jack" ,jack-1) > + ("sdl" ,sdl) > + ("zlib" ,zlib))) > + (native-inputs > + `(("pkg-config" ,pkg-config))) > + (synopsis "Music tracker for working with .MOD/.XM module files") > + (description "MilkyTracker is a music application for creating .MOD = and .XM > +module files. It attempts to recreate the module replay and user experi= ence of > +the popular DOS program Fasttracker II, with special playback modes avai= lable > +for improved Amiga ProTracker 2/3 compatibility.") > + (home-page "http://milkytracker.org/") > + (license license:gpl3))) 4) I looked closer at the licenses. It appeared to be that the code in "src/milkyplay" is under Modified BSD (bsd-3), and the rest is under GPL3 or later (gl3+). The rest looks good to me, so I adjusted your patch for the mentioned notes and committed it=C2=B9. Oh, also I added a copyright line with your name to the beginning of the file. Thanks for contributing! =C2=B9 http://git.savannah.gnu.org/cgit/guix.git/commit/?id=3D21d1811301c4a= cc34dc124c832d21918c2d11a95 --=20 Alex