From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/7] import cran: Remove more invalid characters from package names.
Date: Mon, 23 May 2016 23:54:14 +0200 [thread overview]
Message-ID: <877fekl9tl.fsf@gnu.org> (raw)
In-Reply-To: <1464017539-1478-1-git-send-email-ricardo.wurmus@mdc-berlin.de> (Ricardo Wurmus's message of "Mon, 23 May 2016 17:32:13 +0200")
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
> * guix/import/cran.scm (guix-name): Replace period and underscore with
> dash; always prepend package names with "r-".
[...]
> + (string-append "r-" (string-downcase
> + (regexp-substitute/global #f "(_|\\.)" name
> + 'pre "-" 'post))))
I’d have a preference for ‘string-map’ here. WDYT?
Otherwise looks good!
Ludo’.
next prev parent reply other threads:[~2016-05-23 21:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 15:32 [PATCH 1/7] import cran: Remove more invalid characters from package names Ricardo Wurmus
2016-05-23 21:54 ` Ludovic Courtès [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-05-23 15:40 [PATCH] Add recursive CRAN importer Ricardo Wurmus
2016-05-23 15:40 ` [PATCH 1/7] import cran: Remove more invalid characters from package names Ricardo Wurmus
2016-05-30 8:48 ` Ludovic Courtès
2016-06-14 15:02 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fekl9tl.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).