From: ludo@gnu.org (Ludovic Courtès)
To: guix-devel@gnu.org
Subject: Re: syntax check before commit and patch: net-perl-psyc
Date: Tue, 14 Jun 2016 12:10:05 +0200 [thread overview]
Message-ID: <877fdshyiq.fsf@gnu.org> (raw)
In-Reply-To: <20160613140750.GA11984@khazad-dum> (ng0@we.make.ritual.n0.is's message of "Mon, 13 Jun 2016 14:07:50 +0000")
Hello!
ng0 <ng0@we.make.ritual.n0.is> skribis:
> the following is an insert minus the header etc of
> net-perl-psyc. Before I commit and send in a patch, I'd
> like to check if there's anything I can improve.
Overall it looks good!
> (replace
> 'install
> (lambda* (#:key outputs #:allow-other-keys)
> (let* ((out (assoc-ref outputs "out"))
> (doc (string-append out "/share/doc/perl-net-psyc"))
> (libpsyc (string-append out "/lib/psyc/ion"))
> (libperl (string-append out "/lib/perl5/site_perl/"
> ,(package-version perl)))
> (bin (string-append out "/bin")))
> (copy-recursively "lib/perl5" libperl)
> (copy-recursively "lib/psycion" libpsyc)
> (copy-recursively "bin" bin)
> (install-file "cgi/psycpager" (string-append doc "/cgi"))
> (copy-recursively "contrib" (string-append doc "/contrib"))
> (copy-recursively "hooks" (string-append doc "/hooks"))
> (copy-recursively "sdj" (string-append doc "/sdj"))
> (install-file "README.txt" doc)
> (install-file "TODO.txt" doc)
> #t)))
Doesn’t “./Build install” do that? (This is what ‘perl-build-system’
does, see (guix build perl-build-system).)
> (add-after 'install 'wrap-programs
> (lambda* (#:key outputs #:allow-other-keys)
> ;; Make sure all executables in "bin" find the Perl modules
> ;; provided by this package at runtime.
> (let* ((out (assoc-ref outputs "out"))
> (bin (string-append out "/bin/"))
> (path (string-append out "/lib/perl5/site_perl")))
> (for-each (lambda (file)
> (wrap-program file
> `("PERL5LIB" ":" prefix (,path))))
> (find-files bin "\\.*$"))
> ;; XXX: hooks/dpa2psyc,examples/{recvtest,sendtest},
> ;; cgi/psycpager,contrib/{makenoise,keefchat
> ;; contrib/MovableTypeBlog/plugins/psyc.pl
> #t))))))
This reminds me that we should eventually update ‘perl-build-system’ to
have a ‘wrap’ phase similar to that of ‘python-build-system’.
Thanks,
Ludo’.
next prev parent reply other threads:[~2016-06-14 10:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 14:07 syntax check before commit and patch: net-perl-psyc ng0
2016-06-14 10:10 ` Ludovic Courtès [this message]
2016-06-14 12:39 ` ng0
2016-06-14 12:59 ` Ricardo Wurmus
2016-06-14 14:56 ` [PATCH] " ng0
2016-06-15 13:11 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fdshyiq.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).