From mboxrd@z Thu Jan 1 00:00:00 1970 From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=) Subject: Re: [PATCH 10/10] gnu: Add python-fake-factory and python2-fake-factory. Date: Sun, 26 Jun 2016 10:09:20 +0800 Message-ID: <877fdc4s6n.fsf@member.fsf.org> References: <20160623152004.24065-1-iyzsong@gmail.com> <20160623152004.24065-6-iyzsong@gmail.com> <20160625175842.GI22624@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50425) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGzW0-0001aC-0h for guix-devel@gnu.org; Sat, 25 Jun 2016 22:09:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGzVv-0005Nx-QI for guix-devel@gnu.org; Sat, 25 Jun 2016 22:09:38 -0400 Received: from mail2.openmailbox.org ([62.4.1.33]:57245) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGzVv-0005Nk-KC for guix-devel@gnu.org; Sat, 25 Jun 2016 22:09:35 -0400 In-Reply-To: <20160625175842.GI22624@jasmine> (Leo Famulari's message of "Sat, 25 Jun 2016 13:58:42 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org Leo Famulari writes: > On Thu, Jun 23, 2016 at 11:20:04PM +0800, =E5=AE=8B=E6=96=87=E6=AD=A6 wro= te: >> * gnu/packages/python.scm (python-fake-factory, python2-fake-factory): >> New variables. > >> + (arguments >> + '(#:phases >> + (modify-phases %standard-phases >> + (add-before 'check 'disable-failing-test >> + ;; XXX: faker/tests/ne_np/__init__.py, line 40, in test_names >> + ;; first_name, last_name =3D name.split() >> + ;; ValueError: too many values to unpack (expected 2) >> + (lambda _ >> + (delete-file "faker/tests/ne_np/__init__.py") >> + #t))))) > > It's safe to disable this test? Yes, the provider provides names in (first, last) or (prefix, first, last) forms, I think the test code is just outdated. > >> + (native-inputs >> + `(("python-dateutil" ,python-dateutil-2) >> + ("python-setuptools" ,python-setuptools) >> + ("python-six" ,python-six) >> + ;; For testing >> + ("python-email-validator" ,python-email-validator) >> + ("python-mock" ,python-mock) >> + ("python-ukpostcodeparser" ,python-ukpostcodeparser))) > > It doesn't need to use dateutil, email-validator, and ukpostcodeparser > at run-time? It need dateutil and six at runtime, and they're included in the pth file, I can import them in python from: `guix environment --ad-hoc python python-fake-factory -- python3' IIUC, I don't need to propagate dateutil and six, right? > >> + (home-page "http://github.com/joke2k/faker") >> + (synopsis "Python package that generates fake data") >> + (description >> + "Faker is a Python package that generates fake data such as names, >> +addresses, and phone numbers.") >> + (license license:expat) >> + (properties `((python2-variant . ,(delay python2-fake-factory)))))) >> + >> +(define-public python2-fake-factory >> + (let ((base (package-with-python2 (strip-python2-variant >> + python-fake-factory)))) >> + (package >> + (inherit base) >> + (native-inputs >> + `(("python2-ipaddress" ,python2-ipaddress) >> + ,@(package-native-inputs base)))))) > > I have the same question for python2-ipaddress. Oh, it's needed and missing from PYTHONPATH, I should propagate it. Thanks for the review!