From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] update notmuch and python bindings Date: Mon, 08 Aug 2016 11:20:39 +0300 Message-ID: <877fbrzn6w.fsf@gmail.com> References: <147059611699.9624.567002638658964680@what> <87k2fswf6p.fsf@we.make.ritual.n0.is> <147060243049.9624.3341880405367420885@what> <8737mggrr9.fsf@we.make.ritual.n0.is> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55572) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bWfnh-00032D-Li for guix-devel@gnu.org; Mon, 08 Aug 2016 04:20:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bWfnd-0007si-DO for guix-devel@gnu.org; Mon, 08 Aug 2016 04:20:45 -0400 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:35159) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bWfnc-0007sd-Uk for guix-devel@gnu.org; Mon, 08 Aug 2016 04:20:41 -0400 Received: by mail-wm0-x244.google.com with SMTP id i5so13949632wmg.2 for ; Mon, 08 Aug 2016 01:20:40 -0700 (PDT) In-Reply-To: <8737mggrr9.fsf@we.make.ritual.n0.is> (ng0@we.make.ritual.n0.is's message of "Sun, 07 Aug 2016 22:04:42 +0000") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: ng0 Cc: guix-devel@gnu.org ng0 (2016-08-08 01:04 +0300) wrote: > Troy Sankey writes: > >> Quoting ng0 (2016-08-07 15:29:34) >>> > (inputs >>> > - `(("emacs" ,emacs) >>> > - ("glib" ,glib) >>> > + `(("glib" ,glib) >>> >>> Why is emacs removed? >> >> Please see the commit message :) >> >> Of course I could be misunderstanding something, but it does build >> successfully. I do not normally use emacs, so I was not able to test >> this particular change. Commit message: This also removes the emacs input. Quote from the notmuch NEWS file: Drop dependency on "pkg-config emacs". This only means that emacs is not required for notmuch to be built successfully (it is done for those people who don't use emacs). But it doesn't mean this dependency should be dropped. In Guix we usually include all available features. > Ah, sorry. > I don't want to mix up my notmuch and the review, and I'll be occupied > until tuesday night, so someone who does not rely on a functional > notmuch should review if it works correctly. I find it weird that the > input is dropped. You are right, emacs input shouldn't be dropped. This would lead to non-compiled elisp files (I mean /gnu/store/...-notmuch-0.22.1/share/emacs/site-lisp/ would contain only *.el files but not *.elc). I would rather replace 'emacs' with 'emacs-minimal', also I think it should be moved to 'native-inputs'; but this does not relate to this patch (I'll commit this change separately). -- Alex