From: Chris Marusich <cmmarusich@gmail.com>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: Trying to fix IBus
Date: Thu, 11 Aug 2016 03:51:20 -0700 [thread overview]
Message-ID: <877fbn1suv.fsf@gmail.com> (raw)
In-Reply-To: <878tw3d34a.fsf@elephly.net> (Ricardo Wurmus's message of "Thu, 11 Aug 2016 12:14:13 +0200")
[-- Attachment #1: Type: text/plain, Size: 3730 bytes --]
Ricardo Wurmus <rekado@elephly.net> writes:
> Chris Marusich <cmmarusich@gmail.com> writes:
>
>> Ricardo Wurmus <rekado@elephly.net> writes:
>>
>>> NixOS encountered the same problem:
>>>
>>> https://github.com/NixOS/nixpkgs/pull/14568
>>>
>>> I don’t like their solution to set a variable NIX_PROFILES and let GTK
>>> look for immodule files in each of the directories.
>>
>> Why don't you like their solution? Why do you believe that your
>> proposed solution is better than their solution? We should make sure to
>> choose the best solution available, and right now I'm not sure which one
>> is better.
>
> I find it very inelegant to ask users to specify a list of directories
> containing profiles. A mechanism like that also seems like a hack to
> me, and I’m afraid that we would begin to rely more and more on this to
> “solve” other problems.
>
> Splitting a variable that GTK is already using anyway into two different
> versions just seems a lot cleaner to me. The variable won’t even need
> to be exposed to most users; we could set it automatically when
> generating profiles.
>
> Eventually this will disappear once the GTK devs retire support for
> separate input method modules (I guess this would make IBus a hard
> dependency on GNU systems). At that point we can easily drop our
> patches and the profile hook; a generic GUIX_PROFILES variable, on the
> other hand, would be more difficult to deprecate if it becomes more
> popular (as it has a much broader scope).
That makes sense. I think these are good reasons to favor your solution
instead of the NixOS solution. I think your plan is good.
>>> Instead, I think we should patch both GTK versions to respect
>>> GUIX_GTK2_IM_MODULE_FILE and GUIX_GTK3_IM_MODULE_FILE, and generate
>>> the immodule cache files in a profile hook.
>>>
>>> We did something similar before with GUIX_GTK2_PATH and GUIX_GTK3_PATH.
>>
>> I believe you are referring to this thread:
>>
>> https://lists.gnu.org/archive/html/guix-devel/2015-12/msg00046.html
>>
>> Did that patch actually get committed? If so, why didn't it solve the
>> problem? I've read all the relevant discussions I could find [1], and
>> it isn't clear to me why we need to do what you're suggesting ("patch
>> both GTK versions to respect GUIX_GTK2_IM_MODULE_FILE and
>> GUIX_GTK3_IM_MODULE_FILE, and generate the immodule cache files in a
>> profile hook") if we've already committed the patch presented in the
>> thread above.
>
> Yes, that patch got committed and it actually solved a problem. It is a
> different problem, though. GTK really assumes modules to be in one
> place, which means that with immutable directories we have no other way
> to make things work.
I see. I guess I just wasn't familiar with the other issue. Thank you
for explaining.
One last thing: it seems that the NixOS devs' choice of solution was
influenced by a desire not to require users to rebuild programs that
were previously installed in their profiles [1]. They almost chose a
solution like the one you are proposing, but they changed their minds to
avoid requiring users to rebuild existing programs in their profiles.
GuixSD is still Beta, so I don't think that's an issue for us at all.
[1] See abbradar's comment on April 8th, 2016:
https://github.com/NixOS/nixpkgs/pull/14417#issuecomment-207362530
"This patch would break all such software that uses old (unpatched)
GTK+3."
This appears to be the primary reason why they chose to patch GTK+2 and
GTK+3 to search NIX_PROFILES for an immodules.cache file instead of
patching it to use separate environment variables for GTK+2 and GTK+3.
--
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2016-08-11 10:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 21:09 Trying to fix IBus Ricardo Wurmus
2016-08-10 22:35 ` Alex Griffin
2016-08-11 5:50 ` Ricardo Wurmus
2016-08-11 8:41 ` Chris Marusich
2016-08-11 10:14 ` Ricardo Wurmus
2016-08-11 10:51 ` Chris Marusich [this message]
2016-08-11 13:12 ` Ricardo Wurmus
2016-08-11 13:17 ` Ricardo Wurmus
2016-08-12 16:34 ` Chris Marusich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fbn1suv.fsf@gmail.com \
--to=cmmarusich@gmail.com \
--cc=guix-devel@gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).