From: Ricardo Wurmus <rekado@elephly.net>
To: ng0 <ng0@we.make.ritual.n0.is>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/2] gnu: Add femtolisp.
Date: Wed, 14 Sep 2016 13:05:17 +0200 [thread overview]
Message-ID: <877faeeo7m.fsf@elephly.net> (raw)
In-Reply-To: <871t0miy7t.fsf@we.make.ritual.n0.is>
ng0 <ng0@we.make.ritual.n0.is> writes:
> Ricardo Wurmus <rekado@elephly.net> writes:
>> In this case we should probably split these changes up as they are not
>> related to one another. Alternatively, the summary line should be
>> changed to apply to all of the changes in this patch.
>
> Can you give me an example how the summary line should look like then?
I just checked the git log but couldn’t find a similar package in which
changes of this magnitude were summarised in one commit.
I suggest splitting this up. Actually, though, I think the description
doesn’t need changing. I only suggested removing the sentence because I
assumed that the package didn’t yet exist. There’s no harm in keeping
it.
Without the description change it’s really just one thing that has been
changed:
gnu: femtolisp: Remove custom "patch-makefile" phase.
* gnu/packages/lisp.scm (femtolisp)[arguments]: Remove
"patch-makefile" phase; specify test target; build "release"
target instead of "default".
What do you think?
~~ Ricardo
next prev parent reply other threads:[~2016-09-14 11:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 19:04 [PATCH 1/2] gnu: Add femtolisp ng0
2016-09-13 19:04 ` [PATCH 2/2] gnu: lispf4: Remove unused inputs key ng0
2016-09-13 19:30 ` [PATCH 1/2] gnu: Add femtolisp Ricardo Wurmus
2016-09-13 19:45 ` ng0
2016-09-13 20:32 ` ng0
2016-09-14 9:00 ` Ricardo Wurmus
2016-09-14 9:31 ` ng0
2016-09-14 9:48 ` ng0
2016-09-14 10:03 ` Ricardo Wurmus
2016-09-14 10:15 ` ng0
2016-09-14 11:05 ` Ricardo Wurmus [this message]
2016-09-14 11:17 ` ng0
2016-09-14 12:03 ` ng0
2016-09-18 10:02 ` Andreas Enge
2016-09-20 6:14 ` Ludovic Courtès
2016-09-21 10:37 ` ng0
2016-09-21 15:33 ` Ludovic Courtès
2016-09-21 19:30 ` Ricardo Wurmus
2016-09-22 9:11 ` [PATCH] gnu: femtolisp: Remove support for mips and armhf ng0
2016-09-26 10:38 ` Ludovic Courtès
2016-09-27 8:13 ` ng0
2016-09-27 16:30 ` Leo Famulari
2016-09-18 12:20 ` [PATCH 1/2] gnu: Add femtolisp ng0
2016-09-18 12:25 ` ng0
-- strict thread matches above, loose matches on Subject: below --
2016-09-12 13:57 ng0
2016-09-13 19:40 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877faeeo7m.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=guix-devel@gnu.org \
--cc=ng0@we.make.ritual.n0.is \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).