From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 10/12] gnu: Add slynk.
Date: Sat, 08 Oct 2016 14:59:11 +0200
Message-ID: <877f9jhu8w.fsf@gnu.org>
References: <20160927041532.27097-1-ajpatter@uwaterloo.ca>
	<20160927041532.27097-11-ajpatter@uwaterloo.ca>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59374)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bsrDj-0004pk-BQ
	for guix-devel@gnu.org; Sat, 08 Oct 2016 08:59:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bsrDg-00056u-3a
	for guix-devel@gnu.org; Sat, 08 Oct 2016 08:59:19 -0400
In-Reply-To: <20160927041532.27097-11-ajpatter@uwaterloo.ca> (Andy Patterson's
	message of "Tue, 27 Sep 2016 00:15:30 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Andy Patterson <ajpatter@uwaterloo.ca>
Cc: guix-devel@gnu.org

Andy Patterson <ajpatter@uwaterloo.ca> skribis:

> * gnu/packages/lisp.scm (slynk, slynk-sbcl, slynk-ecl): New variables.

[...]

> +    (synopsis "Common Lisp IDE for Emacs")
> +    (description "SLY is a fork of SLIME.  It also featrues a completely

To make it more standalone, maybe something like: =E2=80=9CSLY is a fork of
SLIME, the foobar IDEish mode for Emacs.=E2=80=9D

Typo: =E2=80=9Cfeatures=E2=80=9D.

> +redesigned REPL based on Emacs's own full-featured comint.el, live code

@file{comint.el}

> +(define slynk-sbcl-boot0
> +  (package
> +    (inherit slynk)
> +    (name "slynk-sbcl")

It=E2=80=99s best to include =E2=80=9C-boot0=E2=80=9D in =E2=80=98name=E2=
=80=99 too.

However, could you add a comment as to what this =E2=80=9Cboot=E2=80=9D pac=
kage does,
and what the general idea is?

> +(define slynk-mrepl-sbcl
> +  (package
> +    (inherit slynk-arglists-sbcl)
> +    (name "slynk-mrepl-sbcl")))
> +
> +(define slynk-mrepl-ecl
> +  (package
> +    (inherit slynk-arglists-ecl)
> +    (name "slynk-mrepl-ecl")))
> +
> +(define slynk-trace-dialog-sbcl
> +  (package
> +    (inherit slynk-arglists-sbcl)
> +    (name "slynk-trace-dialog-sbcl")))
> +
> +(define slynk-trace-dialog-ecl
> +  (package
> +    (inherit slynk-arglists-ecl)
> +    (name "slynk-trace-dialog-ecl")))
> +
> +(define slynk-profiler-sbcl
> +  (package
> +    (inherit slynk-arglists-sbcl)
> +    (name "slynk-profiler-sbcl")))

I don=E2=80=99t follow what=E2=80=99s going on here.  These are all the sam=
e packages as
=E2=80=9Carglists=E2=80=9D but with a different name?  What for?

> +                   (patch-asd-file
> +                    asd-file
> +                    (map
> +                     (lambda (dependency)
> +                       `(,dependency
> +                         . ,(string-append
> +                             (assoc-ref inputs dependency))))

Simply: (cons dependency (assoc-ref =E2=80=A6)), more readable than the dot
notation here.

Thanks,
Ludo=E2=80=99.