unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/1] gnu: borg: Install more documentation.
Date: Tue, 18 Oct 2016 09:19:19 +0200	[thread overview]
Message-ID: <877f96t98o.fsf@elephly.net> (raw)
In-Reply-To: <3cd4136ec4d14a25c803d2dbf2e0262d37a3dc8e.1476759536.git.leo@famulari.name>


Leo Famulari <leo@famulari.name> writes:

> * gnu/packages/backup.scm (borg)[arguments]: Install more documentation
> in 'install-doc' phase.
> ---
>  gnu/packages/backup.scm | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/backup.scm b/gnu/packages/backup.scm
> index eb5e98d..b75e99b 100644
> --- a/gnu/packages/backup.scm
> +++ b/gnu/packages/backup.scm
> @@ -439,8 +439,15 @@ detection, and lossless compression.")
>           (add-after 'install 'install-doc
>             (lambda* (#:key outputs #:allow-other-keys)
>               (let* ((out (assoc-ref outputs "out"))
> -                    (man (string-append out "/share/man/man1")))
> +                    (man (string-append out "/share/man/man1"))
> +                    (misc (string-append out "/share/borg/misc")))
>                 (and
> +                 (for-each (lambda (file)
> +                             (install-file file misc))

I like “cut” from srfi-26 in simple cases like this:

    (for-each (cut install-file <> misc)
              (find-files …))

> +                           (find-files "docs/misc"
> +                                       (string-append "create_chunker-params|"
> +                                                      "internals-picture|"
> +                                                      "prune-example")))

I don’t think “string-append” is needed here.  You can just break the
string and escape the line break.

~~ Ricardo

  reply	other threads:[~2016-10-18  7:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-18  3:03 [PATCH 0/1] Borg: Install more docs Leo Famulari
2016-10-18  3:03 ` [PATCH 1/1] gnu: borg: Install more documentation Leo Famulari
2016-10-18  7:19   ` Ricardo Wurmus [this message]
2016-10-19 20:01     ` Leo Famulari
2016-10-18 16:47   ` Alex Kost
2016-10-19 20:01     ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877f96t98o.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=guix-devel@gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).