From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH 01/16] gnu: Add python-argparse.
Date: Tue, 17 Jan 2017 21:47:43 +0300
Message-ID: <877f5tbk1c.fsf@gmail.com>
References: <20170117141141.11694-1-rekado@elephly.net>
	<20170117141141.11694-2-rekado@elephly.net>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44488)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1cTYnP-0002d8-FG
	for guix-devel@gnu.org; Tue, 17 Jan 2017 13:47:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1cTYnM-00036R-Dd
	for guix-devel@gnu.org; Tue, 17 Jan 2017 13:47:51 -0500
Received: from mail-lf0-x241.google.com ([2a00:1450:4010:c07::241]:36806)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <alezost@gmail.com>) id 1cTYnM-00035t-5m
	for guix-devel@gnu.org; Tue, 17 Jan 2017 13:47:48 -0500
Received: by mail-lf0-x241.google.com with SMTP id h65so17388032lfi.3
	for <guix-devel@gnu.org>; Tue, 17 Jan 2017 10:47:47 -0800 (PST)
In-Reply-To: <20170117141141.11694-2-rekado@elephly.net> (Ricardo Wurmus's
	message of "Tue, 17 Jan 2017 15:11:26 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org

Ricardo Wurmus (2017-01-17 15:11 +0100) wrote:

[...]
> +(define-public python-argparse
> +  (package
> +    (name "python-argparse")
> +    (version "1.4.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "argparse" version))
> +       (sha256
> +        (base32
> +         "1r6nznp64j68ih1k537wms7h57nvppq0szmwsaf99n71bfjqkc32"))))
> +    (properties `((python2-variant . ,(delay python2-argparse))))
> +    (build-system python-build-system)
> +    (home-page "https://pypi.python.org/pypi/argparse/")
> +    (synopsis "Command-line parsing library")
> +    (description "The @code{argparse} module makes it easy to write user
> +friendly command line interfaces.  The program defines what arguments it
> +requires, and @code{argparse} will figure out how to parse those out of
> +@code{sys.argv}.  The @code{argparse} module also automatically generates help
> +and usage messages and issues errors when users give the program invalid
> +arguments.")
> +    (license (package-license python))))
> +
> +(define-public python2-argparse
> +  (package (inherit (package-with-python2
> +              (strip-python2-variant python-argparse)))

I would adjust the indentation here simply by moving "(inherit ..." to
the next line.

> +    (native-inputs
> +     `(("python2-setuptools" ,python2-setuptools)))))
> +
>  (define-public python-ndg-httpsclient
>    (package
>      (name "python-ndg-httpsclient")

-- 
Alex