Re: [PATCH 2/2] gnu: Add mcabber.

[Marius Bakke <mbakke@fastmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2252 bytes --]

contact.ng0@cryptolab.net writes:

> From: ng0 <ng0@libertad.pw>
>
> * gnu/packages/messaging.scm (mcabber): New variable.
> ---
>  gnu/packages/messaging.scm | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
>
> diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
> index d6b0d4bbc..bf351bdc2 100644
> --- a/gnu/packages/messaging.scm
> +++ b/gnu/packages/messaging.scm
> @@ -37,6 +37,7 @@
>    #:use-module (guix build-system cmake)
>    #:use-module (gnu packages)
>    #:use-module (gnu packages aidc)
> +  #:use-module (gnu packages aspell)
>    #:use-module (gnu packages autotools)
>    #:use-module (gnu packages avahi)
>    #:use-module (gnu packages base)
> @@ -1150,4 +1151,36 @@ and yet extensible to let you do anything the Jabber protocol allows.")
>      (synopsis "Asynchronous XMPP library")
>      (license license:lgpl2.1)))
>  
> +(define-public mcabber
> +  (package
> +    (name "mcabber")
> +    (version "1.0.4")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://mcabber.com/files/"
> +                           name "-" version ".tar.bz2"))
> +       (sha256
> +        (base32
> +         "02nfn5r7cjpnacym95l6bvczii232v3x2gi79gfa9syc7w0brdk3"))))
> +    (build-system gnu-build-system)
> +    (inputs
> +     `(("gpgme" ,gpgme)
> +       ("libotr" ,libotr)
> +       ("aspell" ,aspell)
> +       ("libidn" ,libidn)
> +       ("glib" ,glib)
> +       ("ncurses" ,ncurses)
> +       ("loudmouth" ,loudmouth)))
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (home-page "http://mcabber.com")
> +    (description
> +     "Mcabber is a small XMPP (Jabber) console client, which includes features
> +such as SASL and TLS support, @dfn{Multi-User Chat (MUC)} support, logging,
> +command-completion, OpenPGP encryption, @dfn{Off-the-Record Messaging (OTR)}
> +support, and more.")
> +    (synopsis "Small XMPP console client")
> +    (license license:gpl2+)))

AFAICT the parenthesis comes after @dfn{...}. I also noticed libotr and
aspell was not referenced, and had to explicitly enable them as
configure flags. Home page was corrected to HTTPS too. Pushed!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]