From: ludo@gnu.org (Ludovic Courtès)
To: manolis837@gmail.com
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: coreutils: Fix cross-compilation.
Date: Wed, 25 Jan 2017 19:01:38 +0100 [thread overview]
Message-ID: <877f5jvx19.fsf@gnu.org> (raw)
In-Reply-To: <20170125150601.9723-1-manolis837@gmail.com> (manolis's message of "Wed, 25 Jan 2017 17:06:01 +0200")
Hi Manolis!
manolis837@gmail.com skribis:
> From: Manolis Ragkousis <manolis837@gmail.com>
>
> * gnu/packages/patches/coreutils-fix-cross-compilation.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.
> * gnu/packages/base.scm [source]: Use it.
[...]
> --- /dev/null
> +++ b/gnu/packages/patches/coreutils-fix-cross-compilation.patch
> @@ -0,0 +1,15 @@
> +Coreutils fails to cross compile for other platforms because cu_install_program
> +is not being evaluated properly. This patch fixes it.
> +See <https://lists.gnu.org/archive/html/coreutils/2017-01/msg00039.html>
> +--- a/Makefile.in
> ++++ b/Makefile.in
> +@@ -5023,7 +5023,7 @@ pr = progs-readme
> + @CROSS_COMPILING_FALSE@cu_install_program = src/ginstall
> +
> + # Use the just-built 'ginstall', when not cross-compiling.
> +-@CROSS_COMPILING_TRUE@cu_install_program = @INSTALL_PROGRAM@
> ++@CROSS_COMPILING_TRUE@cu_install_program := @INSTALL@
> + info_TEXINFOS = doc/coreutils.texi
LGTM! Even if upstream settles on a different approach, this patch is
fine for our purposes.
Thanks for investigating!
Ludo’.
prev parent reply other threads:[~2017-01-25 18:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 15:06 [PATCH] gnu: coreutils: Fix cross-compilation manolis837
2017-01-25 18:01 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877f5jvx19.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=manolis837@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).