From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] gnu: Add emacs-pretty-mode. Date: Fri, 03 Feb 2017 11:15:29 +0300 Message-ID: <877f57k7vi.fsf@gmail.com> References: <20170201180831.17599-1-contact.ng0@cryptolab.net> <20170201180831.17599-2-contact.ng0@cryptolab.net> <87lgtpt0k3.fsf@gmail.com> <8760ks7vm9.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZZ1q-0003nG-4f for guix-devel@gnu.org; Fri, 03 Feb 2017 03:15:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZZ1m-0002CJ-R3 for guix-devel@gnu.org; Fri, 03 Feb 2017 03:15:34 -0500 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:34483) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cZZ1m-0002C1-JT for guix-devel@gnu.org; Fri, 03 Feb 2017 03:15:30 -0500 Received: by mail-lf0-x244.google.com with SMTP id q89so883358lfi.1 for ; Fri, 03 Feb 2017 00:15:30 -0800 (PST) In-Reply-To: <8760ks7vm9.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me> (ng0's message of "Thu, 02 Feb 2017 10:08:46 +0000") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: ng0 Cc: guix-devel@gnu.org ng0 (2017-02-02 10:08 +0000) wrote: > Alex Kost writes: > >> contact.ng0@cryptolab.net (2017-02-01 18:08 +0000) wrote: >> >>> From: ng0 >>> >>> * gnu/packages/emacs.scm (emacs-pretty-mode): New variable. >>> --- >>> gnu/packages/emacs.scm | 23 +++++++++++++++++++++++ >>> 1 file changed, 23 insertions(+) >>> >>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm >>> index df7f7869d..a51b5de1d 100644 >>> --- a/gnu/packages/emacs.scm >>> +++ b/gnu/packages/emacs.scm >>> @@ -3778,3 +3778,26 @@ customizable by the user.") >>> Additionally it can display the number of unread emails in the >>> mode-line.") >>> (license license:gpl3+))) >>> + >>> +(define-public emacs-pretty-mode >>> + (let ((commit "500085206e25b98d00b9ec996f91c87ba569c4ce") >>> + (revision "1")) >>> + (package >>> + (name "emacs-pretty-mode") >>> + (version (string-append "2.0.3-" revision "." (string-take commit 7))) >>> + (source >>> + (origin >>> + (method git-fetch) >>> + (uri (git-reference >>> + (url "https://github.com/akatov/pretty-mode") >>> + (commit commit))) >> >> Why git commit, and not the latest snapshot? >> >> https://github.com/akatov/pretty-mode/archive/2.0.3.tar.gz > > I wasn't sure. Melpa uses a git commit (I think) and the last > release is very old. I picked the commit because I thought it > would be incompatible to current emacs. Of course it is compatible. Melpa always uses the latest commit. And Melpa-Stable uses the latest tag (which is 2.0.3): http://stable.melpa.org/#/pretty-mode My understanding of Guix packaging policy is that we try to package the latest releases (or latest tag snapshots if there is no release tarball), and to use git commits only if there are significant bug or security fixes. Otherwise, why don't we use git-fetch everywhere? BTW it is not "very old", it is 10 commits behind master, and all these commits are rather minor, as you can see: https://github.com/akatov/pretty-mode/compare/2.0.3...master >>> + (file-name (string-append name "-" version "-checkout")) >>> + (sha256 >>> + (base32 >>> + "0m7ii971zxlz8a9yx2ljf9fmd8k6hc9w1q8mi5xi32v9viccjabs")))) >>> + (build-system emacs-build-system) >>> + (home-page "https://github.com/akatov/pretty-mode") >>> + (synopsis "Redisplay parts of the buffer as pretty Unicode symbols.") >>> + (description >>> + "Emacs minor mode for redisplaying parts of the buffer as pretty symbols.") >>> + (license license:gpl3+)))) -- Alex