Add emacs-dream-theme

Add emacs-dream-theme

[contact.ng0]

There are no releases, and I don't know how/if there are certain expectations about themes. If loading them just via (require 'dream) is not normal, should it be mentioned in the description?
See http://www.djcbsoftware.nl/dot-emacs.html for an example.

[PATCH] gnu: Add emacs-dream-theme.

[contact.ng0]

From: ng0 <contact.ng0@cryptolab.net>

* gnu/packages/emacs.scm (emacs-dream-theme): New variable.
---
 gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index dfdf32496..04ac96e33 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -3490,6 +3490,30 @@ known loosely as deftheme.  Many mode-specific customizations are included.")
        "@code{danneskjold-theme} is a high-contrast theme for Emacs.")
       (license license:gpl3+))))
 
+(define-public emacs-dream-theme
+  (let* ((commit "107a11d74365046f28a1802a2bdb5e69e4a7488b")
+         (revision "1"))
+    (package
+      (name "emacs-dream-theme")
+      (version (string-append "0.0.0-" revision "." (string-take commit 7)))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/djcb/dream-theme")
+               (commit commit)))
+         (file-name (string-append name "-" version "-checkout"))
+         (sha256
+          (base32
+           "0za18nfkq4xqm35k6006vsixcbmvmxqgma4iw5sw37h8vmcsdylk"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/djcb/dream-theme")
+      (synopsis "High-contrast Emacs theme")
+      (description
+       "@code{dream-theme} is a dark, clean theme for Emacs.  It is inspired
+by zenburn, sinburn and similar themes, but slowly diverging from them.")
+      (license license:gpl3+))))
+
 (define-public emacs-auto-complete
   (package
     (name "emacs-auto-complete")
-- 
2.11.0

Re: Add emacs-dream-theme

[Alex Kost]

contact.ng0@cryptolab.net (2017-02-03 20:34 +0000) wrote:

> There are no releases, and I don't know how/if there are certain
> expectations about themes. If loading them just via (require 'dream) is
> not normal, should it be mentioned in the description?
> See http://www.djcbsoftware.nl/dot-emacs.html for an example.

I would say it is not normal, well at least it is not user friendly.  A
usual practice for (M)ELPA theme packages is to autoload a bit of code
that adds a theme to 'custom-theme-load-path' so the theme can be used
without additional settings.  But since this package autoloads nothing,
a user has to adjust their emacs config to make this theme available.
I'm not sure if it should be mentioned in the description though.

-- 
Alex