From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marius Bakke <mbakke@fastmail.com>
Subject: Re: 01/01: gnu: grub-efi: Really build the EFI variant.
Date: Tue, 07 Feb 2017 17:20:03 +0100
Message-ID: <877f52ht1o.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>
References: <20170207101551.13623.62644@vcs.savannah.gnu.org>
	<20170207101551.F0842220055@vcs.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52286)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mbakke@fastmail.com>) id 1cb8V0-0004Kw-Q7
	for guix-devel@gnu.org; Tue, 07 Feb 2017 11:20:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mbakke@fastmail.com>) id 1cb8Uw-0003pv-ON
	for guix-devel@gnu.org; Tue, 07 Feb 2017 11:20:10 -0500
In-Reply-To: <20170207101551.F0842220055@vcs.savannah.gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>, guix-devel@gnu.org

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Ludovic Court=C3=A8s <ludo@gnu.org> writes:

> civodul pushed a commit to branch master
> in repository guix.
>
> commit ef753a1a8f9e7c971957abfda9b672a7728cd073
> Author: Ludovic Court=C3=A8s <ludo@gnu.org>
> Date:   Tue Feb 7 11:14:09 2017 +0100
>
>     gnu: grub-efi: Really build the EFI variant.
>=20=20=20=20=20
>     Fixes a regression introduced in
>     d846834fc2b2f76aa2e258685bc211edd31866c5 where '--with-platform=3Defi'
>     would no longer be passed.
>=20=20=20=20=20
>     * gnu/packages/grub.scm (grub-efi)[arguments]: Provide a default value
>     for #:configure-flags.

[...]

> @@ -139,8 +139,8 @@ menu to select one of the installed operating systems=
.")
>         ;; Search for 'OVMF' in "tests/util/grub-shell.in".
>         #:tests? #f
>         ,@(substitute-keyword-arguments (package-arguments grub)
> -           ((#:configure-flags flags) `(cons* "--with-platform=3Defi"
> -                                              ,flags))
> +           ((#:configure-flags flags ''())
> +            `(cons "--with-platform=3Defi" ,flags))
>             ((#:phases phases)
>              `(modify-phases ,phases
>                 (add-after 'patch-stuff 'use-absolute-efibootmgr-path

Thank you for this! I did test grub-efi with the new grub release, but
then afterwards checked whether the #:configure-flags were still needed.

I will be more careful about this in the future.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAliZ87MACgkQoqBt8qM6
VPpioQf/dGSsbEzoksgkOBZCffGV/wIknIZrQeU7fQCsbnAyqvyI8a3botUKvgMG
eGW1xBhYAdBqDIQbd1nf7/JZMTISv5t42Aro+715J3+i3jJyDXVaynUOFKqm9mov
pbNK/db6IfjIKqc1Af//0Q9usw42RJvxblKFeJe1kc+ixI1SLNkQ4iswkyiuQk9u
xPputjWgvuZnm4S+v+J/jBUbAO0bQFKY/KejR9dawZYBo3MADyuAcs+A4u/k/ymh
nPCrzcL7/7t0/enYcCc+qiVYdZEswImQu7UZ+oBwqxZ9I88hJvH8fEQcDdWP3g4i
5MplowAW9SuY9Wrj6SguWxdCh335Vw==
=mOQD
-----END PGP SIGNATURE-----
--=-=-=--